From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: LiangCheng Wang <zaq14760@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v9 2/3] staging: media: atomisp: fix indentation in anr
Date: Fri, 11 Jul 2025 15:25:18 +0300 [thread overview]
Message-ID: <aHECrvSQCicV5nP5@smile.fi.intel.com> (raw)
In-Reply-To: <20250711-new_atomisp-v9-2-a9dd62425ef6@gmail.com>
On Fri, Jul 11, 2025 at 07:54:37PM +0800, LiangCheng Wang wrote:
> This patch fixes tab/space indentation issues in anr
> following kernel coding style guidelines.
>
> No functional logic changes were made.
Same comments about Link tags and suggestions in general.
...
> 0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> 0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4
Side note, would be nice to add a trailing comma here.
I think it's okay to do in this patch as this is not
enough for a separate change and the driver in staging,
the rules are slightly relaxed on it.
> },
> - {10, 20, 30}
> + { 10, 20, 30 },
> };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-11 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 11:54 [PATCH v9 0/3] staging: media: atomisp: indentation cleanup per directory LiangCheng Wang
2025-07-11 11:54 ` [PATCH v9 1/3] staging: media: atomisp: fix indentation in aa LiangCheng Wang
2025-07-11 12:22 ` Andy Shevchenko
2025-07-11 11:54 ` [PATCH v9 2/3] staging: media: atomisp: fix indentation in anr LiangCheng Wang
2025-07-11 12:25 ` Andy Shevchenko [this message]
2025-07-11 11:54 ` [PATCH v9 3/3] staging: media: atomisp: fix indentation in bh LiangCheng Wang
2025-07-11 12:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHECrvSQCicV5nP5@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=zaq14760@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®