From: Feng Tang <feng.tang@linux.alibaba.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Petr Mladek <pmladek@suse.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [rft, PATCH v1 0/7] panic: sys_info: Refactor and fix a compilation issue
Date: Fri, 11 Jul 2025 23:42:13 +0800 [thread overview]
Message-ID: <aHEw1U8x5WfGaMsC@U-2FWC9VHC-2323.local> (raw)
In-Reply-To: <aHD_1QopiVCU-vzh@smile.fi.intel.com>
On Fri, Jul 11, 2025 at 03:13:09PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 11, 2025 at 12:51:06PM +0300, Andy Shevchenko wrote:
> > While targeting the compilation issue due to dangling variable,
> > I have noticed more opportunities for refactoring that helps to
> > avoid above mentioned compilation issue and make code cleaner in
> > general. Please, give it a try.
> >
> > I put a revert as the first patch of the previous solution, but I believe
> > the previous solution may be pulled out without a problem.
>
> Btw, I can try to pop the fix upper in the series, but since this
> whole feature was only a few days old, I propose to drop it completely
> for now and start again. Please, Cc me for the review.
Can we just take your fix and nice cleanups? Do we really need to drop
the whole series? My gcc haven't raised warnings in the past several
versions, and I will install clang for more complete compiling test
beside functional test for future patches.
Anyway I don't think it has fundamental blocking issue, but I'm fine
if you insist to do so.
Thanks,
Feng
> --
> With Best Regards,
> Andy Shevchenko
>
next prev parent reply other threads:[~2025-07-11 15:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:51 Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 1/7] Revert "panic: fix compilation error (`make W=1`)" Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 2/7] panic: sys_info: Align constant definition names with parameters Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 3/7] panic: sys_info: Capture si_bits_global before iterating over it Andy Shevchenko
2025-07-11 14:56 ` Feng Tang
2025-07-11 15:05 ` Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 4/7] panic: sys_info: Replace struct sys_info_name with plain array of strings Andy Shevchenko
2025-07-11 15:21 ` Feng Tang
2025-07-11 16:26 ` Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 5/7] panic: sys_info: Fix compilation error (`make W=1`) Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 6/7] panic: sys_info: Deduplicate local variable 'table; assignments Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 7/7] panic: sys_info: Factor out read and write handlers Andy Shevchenko
2025-07-11 15:09 ` Feng Tang
2025-07-11 16:34 ` Andy Shevchenko
2025-07-11 12:13 ` [rft, PATCH v1 0/7] panic: sys_info: Refactor and fix a compilation issue Andy Shevchenko
2025-07-11 15:42 ` Feng Tang [this message]
2025-07-11 16:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHEw1U8x5WfGaMsC@U-2FWC9VHC-2323.local \
--to=feng.tang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®