From: Boqun Feng <boqun.feng@gmail.com>
To: Waiman Long <llong@redhat.com>
Cc: ranxiaokai627@163.com, peterz@infradead.org, mingo@redhat.com,
will@kernel.org, linux-kernel@vger.kernel.org,
ran.xiaokai@zte.com.cn
Subject: Re: [PATCH] locking/mutex: remove redundant ifdef
Date: Fri, 11 Jul 2025 15:17:21 -0700 [thread overview]
Message-ID: <aHGNcZe-gwO53QFF@tardis-2.local> (raw)
In-Reply-To: <6a687f94-770b-4fa8-83be-978007e902b6@redhat.com>
On Fri, Jul 04, 2025 at 09:57:35AM -0400, Waiman Long wrote:
>
> On 7/3/25 9:52 PM, ranxiaokai627@163.com wrote:
> > From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> >
> > hung_task_set/clear_blocker() is already guarded by
> > CONFIG_DETECT_HUNG_TASK_BLOCKER in hung_task.h, So remove
> > the redudant check of #ifdef.
> >
> > Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
Queued for v6.17, thanks!
Regards,
Boqun
> > ---
> > kernel/locking/mutex.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
> > index a39ecccbd106..d4210dc97b6a 100644
> > --- a/kernel/locking/mutex.c
> > +++ b/kernel/locking/mutex.c
> > @@ -191,9 +191,7 @@ static void
> > __mutex_add_waiter(struct mutex *lock, struct mutex_waiter *waiter,
> > struct list_head *list)
> > {
> > -#ifdef CONFIG_DETECT_HUNG_TASK_BLOCKER
> > hung_task_set_blocker(lock, BLOCKER_TYPE_MUTEX);
> > -#endif
> > debug_mutex_add_waiter(lock, waiter, current);
> > list_add_tail(&waiter->list, list);
> > @@ -209,9 +207,7 @@ __mutex_remove_waiter(struct mutex *lock, struct mutex_waiter *waiter)
> > __mutex_clear_flag(lock, MUTEX_FLAGS);
> > debug_mutex_remove_waiter(lock, waiter, current);
> > -#ifdef CONFIG_DETECT_HUNG_TASK_BLOCKER
> > hung_task_clear_blocker();
> > -#endif
> > }
> > /*
> Acked-by: Waiman Long <longman@redhat.com>
>
next prev parent reply other threads:[~2025-07-11 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 1:52 ranxiaokai627
2025-07-04 13:57 ` Waiman Long
2025-07-11 22:17 ` Boqun Feng [this message]
2025-07-19 17:40 ` [tip: locking/core] locking/mutex: Remove redundant #ifdefs tip-bot2 for Ran Xiaokai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHGNcZe-gwO53QFF@tardis-2.local \
--to=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llong@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=ranxiaokai627@163.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®