Hi Andy, many thanks for the thorough review. One comment below. Andy Shevchenko schrieb am Mo, 26. Mai 23:17: > > +/** > > + * struct veml6046x00_data - Private data of driver. > > + * @regmap: Regmap definition of sensor. > > + * @trig: Industrial-IO trigger. > > + * @rf: Regmap field of configuration. > > + */ > > +struct veml6046x00_data { > > + struct regmap *regmap; > > + struct iio_trigger *trig; > > + struct veml6046x00_rf rf; > > Does pahole agree on the choice of the layout? This is the output of pahole: struct veml6046x00_data { struct regmap * regmap; /* 0 4 */ struct iio_trigger * trig; /* 4 4 */ struct veml6046x00_rf rf; /* 8 20 */ /* size: 28, cachelines: 1, members: 3 */ /* last cacheline: 28 bytes */ }; I don't see anything wrong or did i miss something? Best regards, Andreas