From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Simon Horman <horms@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, Andre Edich <andre.edich@microchip.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net v3 2/3] net: phy: allow drivers to disable polling via get_next_update_time()
Date: Mon, 14 Jul 2025 11:53:56 +0200 [thread overview]
Message-ID: <aHTTtHsYDP3YXgmF@pengutronix.de> (raw)
In-Reply-To: <20250712131848.GA721198@horms.kernel.org>
On Sat, Jul 12, 2025 at 02:18:48PM +0100, Simon Horman wrote:
> > + if (phydev->drv->update_stats) {
> > + WARN_ONCE("phy: %s: driver requested IRQ mode but needs polling for stats\n",
> > + phydev_name(phydev));
>
> The first argument to WARN_ONCE() should be a condition, not a format string.
>
> Flagged by GCC and Clang builds with KCFLAGS=-Wformat-security
Thank you! I added it to my build test setup.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-07-14 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:49 [PATCH net v3 0/3] net: phy: smsc: use IRQ + relaxed polling to fix missed link-up Oleksij Rempel
2025-07-11 9:49 ` [PATCH net v3 1/3] net: phy: enable polling when driver implements get_next_update_time Oleksij Rempel
2025-07-11 9:49 ` [PATCH net v3 2/3] net: phy: allow drivers to disable polling via get_next_update_time() Oleksij Rempel
2025-07-12 13:18 ` Simon Horman
2025-07-14 9:53 ` Oleksij Rempel [this message]
2025-07-11 9:49 ` [PATCH net v3 3/3] net: phy: smsc: recover missed link-up IRQs on LAN8700 with adaptive polling Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHTTtHsYDP3YXgmF@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andre.edich@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®