mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Animesh Agarwal <animeshagarwal28@gmail.com>,
	"open list:CLOCKSOURCE,
	CLOCKEVENT DRIVERS" <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: timer: fsl,ftm-timer: use items for reg
Date: Mon, 14 Jul 2025 11:24:29 -0400	[thread overview]
Message-ID: <aHUhLSDQ/vdrg3hX@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250523141437.533643-1-Frank.Li@nxp.com>

On Fri, May 23, 2025 at 10:14:37AM -0400, Frank Li wrote:
> The original txt binding doc is:
>   reg : Specifies base physical address and size of the register sets for
>         the clock event device and clock source device.
>
> And existed dts provide two reg MMIO spaces. So change to use items to
> descript reg property.
>
> Update examples.
>
> Fixes: 8fc30d8f8e86 ("dt-bindings: timer: fsl,ftm-timer: Convert to dtschema")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Daniel Lezcano Or Rob

Krzysztof Kozlowski already reviewed. Could you place pick this one?

Frank

> ---
> change in v2
> - add kk review tag
> - add missed )
> ---
>  Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> index 0e4a8ddc3de32..e3b61b62521e8 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.yaml
> @@ -14,7 +14,9 @@ properties:
>      const: fsl,ftm-timer
>
>    reg:
> -    maxItems: 1
> +    items:
> +      - description: clock event device
> +      - description: clock source device
>
>    interrupts:
>      maxItems: 1
> @@ -50,7 +52,8 @@ examples:
>
>      ftm@400b8000 {
>          compatible = "fsl,ftm-timer";
> -        reg = <0x400b8000 0x1000>;
> +        reg = <0x400b8000 0x1000>,
> +              <0x400b9000 0x1000>;
>          interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>;
>          clock-names = "ftm-evt", "ftm-src", "ftm-evt-counter-en", "ftm-src-counter-en";
>          clocks = <&clks VF610_CLK_FTM2>, <&clks VF610_CLK_FTM3>,
> --
> 2.34.1
>

  reply	other threads:[~2025-07-14 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 14:14 Frank Li
2025-07-14 15:24 ` Frank Li [this message]
2025-07-14 16:04   ` Krzysztof Kozlowski
2025-07-14 16:12   ` Daniel Lezcano
2025-07-14 16:15 ` Daniel Lezcano
2025-07-23  7:17 ` [tip: timers/clocksource] " tip-bot2 for Frank Li
2025-07-25 10:31 ` [tip: timers/clocksource] dt-bindings: timer: fsl,ftm-timer: Use 'items' for 'reg' tip-bot2 for Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHUhLSDQ/vdrg3hX@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=animeshagarwal28@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®