From: Christoph Hellwig <hch@infradead.org>
To: linux@treblig.org
Cc: akpm@linux-foundation.org, terrelln@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/xxhash: Comment out unused functions
Date: Mon, 14 Jul 2025 23:09:03 -0700 [thread overview]
Message-ID: <aHXwfyKRvXi5AZZT@infradead.org> (raw)
In-Reply-To: <20250714000927.294767-1-linux@treblig.org>
On Mon, Jul 14, 2025 at 01:09:27AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> xxh32_digest() and xxh32_update() were added in 2017 in the original
> xxhash commit, but have remained unused.
>
> While I've mostly been deleting unused functions, this is a general
> library and I see erofs is using other bits of xxh32, so it didn't
> seem right just to delete them.
>
> Comment them out with #if 0.
> (Which checkpatch rightly warns about)
Please just remove it like all other dead code. The same argument
that folks can easily look at the git history to resurrect it applies
here as everywhere else.
next prev parent reply other threads:[~2025-07-15 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 0:09 linux
2025-07-15 6:09 ` Christoph Hellwig [this message]
2025-07-16 13:33 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHXwfyKRvXi5AZZT@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®