From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7FDF1F3BAB for ; Tue, 15 Jul 2025 17:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752600196; cv=none; b=Ijv8tKN8RbR64CCBsA3tik6we1OXn6lt6L2mfGKqTbCKeCLiGb8QEg5r/OhMWzfqayKxyidU5N9aqtZqxPrTMD+FdCE3fxjWfZtS18ezsKcFPfmXi14llZiQkKwCjT5qbVgGToz0gOf/KClBhqZw+nAvvrgK/77+V6ekBzMgGFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752600196; c=relaxed/simple; bh=mCCWuV6Odut3uFczrkLcBwk95v4G96gg/5yw1QP4OoI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZG2iNOoV5CobpMoUgmOyoebPMMs3LhUcnGc9fIIe7uG4G/FrDUdvfvVSUDdm+Bpg9YkpPA4ovMmYN2urN8qgTUQ9cBerhufx80ArYkaCYSyv7u8SujT4+ZzlI3ikHQal9zdWBdbiWGnCimViV0DjBzTKUvyoYSN2KvU9TyEIzAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=b4XY0FZV; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="b4XY0FZV" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-23e210ebd5dso748835ad.1 for ; Tue, 15 Jul 2025 10:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752600194; x=1753204994; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JeSwPftceeI4bS5ZJ/5dVmNBTZSjRvLVPg9Q3yUXq/U=; b=b4XY0FZVD30gT3SeXKcFFVHwEM3WlBIuldn2vbqlG7fJ24L349gcrUH7xf8Np1MEEg tTlkQsxjxTNE1b42lNmqV+Vd3XuYPoYpd2Frix2PgwMiMQBRqdIRWnq2tDIbY2xQwWxn gU/PzjMzG8T50M0p+2EWQLKCwcPLrOJLrATXBWCIQpxIK7jbNpbE8QC0bgtHYsua+T8x Qh/wwvt/5YP+0Z1oVDmvAMZwMcHQiIugZMvtRMEGSLkBZCOC0DzVOARUsbXKVh5fy2qK ZfClTDJYX5+vdyCGr9rzs6VoUz4YEDU9uDP7ABjmAuVfrticYGblpg766F+caQkUtP27 QR/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752600194; x=1753204994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JeSwPftceeI4bS5ZJ/5dVmNBTZSjRvLVPg9Q3yUXq/U=; b=iv+9MHPYbBTWpxYxHPqpGa0tkKUZHpFR/mW2gYvFYHGx6gvNNAgJo/R9sVS8KbymEf Srru54mRt5Ygpbf1WJBJo1cCkWnHNiUC5CA4qPr+MxBymk/ZSI9kQ1+EzwmqgGq0SQLF AteqGWVBqmkK7JY6V6vudn+NYm5FnmsC+hO2udkkvwQsIwY0JQKB0t4Kl1A0JLmcoQX/ KlCTsQsTtT9l9T/AUkQD19nhG8Fmd5vjcGSQK/vylZQLvgRoy6kp1WKBjB3SaHoQrmOq OV3YZpUDBSi/4JhPkkuK4TbHy2XpoIUhNOb/TkWaGZcyzGQ8DYHRr5qlOetCgbEgR2qz RiYA== X-Forwarded-Encrypted: i=1; AJvYcCUU396Ovel3yMGMz8serx1hw7QzucZT74MZLCyQuCCqmenhLqsoyk2N9usp23rEk5vo1PK0ZzcDNZC4qtg=@vger.kernel.org X-Gm-Message-State: AOJu0YwugdUc8ps/idbfYdxUZvsniX5bh1TrTK5ZoVo+MvkzQp54N0aI A/QoPM+8v83SKr3kZAJWS9usL+fAoko1q23gUrbW1R2hRWad7xk5f+utBzxeFa+Htw== X-Gm-Gg: ASbGncvSkQzHMcjlT2B808TzPhMYSvUFVIvZjTqHaCwN8PgfZ7P1xdpEYEZoj6disQP d31/MvDtSChckUG9V/5iufIwbAiWnEx4Kj8yihL8AtBU+uPITRcD8HjJ8a6+LdqZb3s5YPiSDtU ZxvrN2P9BFNxueCtmbCSNRIPFa2BcMmVnWLpnQADOnNcS3+prqVnPcLbWoXUPlI6wO+rcVznJxU TpZBLF9+ocBnN3MTrzLBDzh+UHboZrEVB0sNH1YIpi3eSWkeMLfMn0cVS/tzayWYOsRF9NsqP00 Xp/c6k9zzCv58HRBSg+KrWnb2Pwr6UiOHY2YiQhAwJCQNvLrHmDvHrqmSOQBZrDbkZwkBiihpon I/b5RasUwDOv9ccTA5yNJR2Sw3rlnqZoyh/r+Czm/W/77+vQrPihXCOQ7PWpfgds= X-Google-Smtp-Source: AGHT+IE8tlVGhJEdemSXyXUpK0hF30ss3dhi3KqymqtfDaNyMz+jAYsoKXuNfguzst4OMQTFv0uS9A== X-Received: by 2002:a17:903:1248:b0:231:c89f:4e94 with SMTP id d9443c01a7336-23e1a4c71e3mr67028215ad.21.1752600193877; Tue, 15 Jul 2025 10:23:13 -0700 (PDT) Received: from google.com (152.33.83.34.bc.googleusercontent.com. [34.83.33.152]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de4332eadsm116684575ad.153.2025.07.15.10.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 10:23:13 -0700 (PDT) Date: Tue, 15 Jul 2025 10:23:09 -0700 From: William McVicker To: Daniel Lezcano Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Alim Akhtar , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" Subject: Re: [PATCH] clocksource/drivers/exynos_mct: Fix section mismatch from the module conversion Message-ID: References: <20250620181719.1399856-6-willmcvicker@google.com> <20250715121834.2059191-1-daniel.lezcano@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250715121834.2059191-1-daniel.lezcano@linaro.org> On 07/15/2025, Daniel Lezcano wrote: > The function register_current_timer_delay() when compiling on ARM32 > fails with a section mismatch. That is resulting from the module > conversion where the function exynos4_clocksource_init() is called > from mct_init_dt(). This one had its __init annotation removed to for > the module loading. > > Fix this by adding the __init_or_module annotation for the functions: > - mct_init_dt() > - mct_init_spi() > - mct_init_dt() > > Compiled on ARM32 + MODULES=no, ARM64 + MODULES=yes, ARM64 + > MODULES=no > > Signed-off-by: Daniel Lezcano Reviewed-by: Will McVicker > --- > drivers/clocksource/exynos_mct.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c > index 5075ebe052a7..80d263ee046d 100644 > --- a/drivers/clocksource/exynos_mct.c > +++ b/drivers/clocksource/exynos_mct.c > @@ -657,7 +657,7 @@ static int exynos4_timer_interrupts(struct device_node *np, > return err; > } > > -static int mct_init_dt(struct device_node *np, unsigned int int_type) > +static __init_or_module int mct_init_dt(struct device_node *np, unsigned int int_type) > { > bool frc_shared = of_property_read_bool(np, "samsung,frc-shared"); > u32 local_idx[MCT_NR_LOCAL] = {0}; > @@ -705,12 +705,12 @@ static int mct_init_dt(struct device_node *np, unsigned int int_type) > return exynos4_clockevent_init(); > } > > -static int mct_init_spi(struct device_node *np) > +static __init_or_module int mct_init_spi(struct device_node *np) > { > return mct_init_dt(np, MCT_INT_SPI); > } > > -static int mct_init_ppi(struct device_node *np) > +static __init_or_module int mct_init_ppi(struct device_node *np) > { > return mct_init_dt(np, MCT_INT_PPI); > } > -- > 2.43.0 > Thanks Daniel for catching this! Sorry I missed it. Regards, Will