From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Will McVicker" <willmcvicker@google.com>,
kernel-team@android.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: devres: release GPIOs in devm_gpiod_put_array()
Date: Wed, 16 Jul 2025 12:30:46 +0300 [thread overview]
Message-ID: <aHdxRvJ6fCEiQ6Rn@smile.fi.intel.com> (raw)
In-Reply-To: <175265695302.15922.15433902408963854171.b4-ty@linaro.org>
On Wed, Jul 16, 2025 at 11:09:31AM +0200, Bartosz Golaszewski wrote:
> On Tue, 15 Jul 2025 17:00:20 +0100, André Draszik wrote:
> > devm_gpiod_put_array() is meant to undo the effects of
> > devm_gpiod_get_array() - in particular, it should release the GPIOs
> > contained in the array acquired with the latter. It is meant to be the
> > resource-managed version of gpiod_put_array(), and it should behave
> > similar to the non-array version devm_gpiod_put().
> >
> > Since commit d1d52c6622a6 ("gpiolib: devres: Finish the conversion to
> > use devm_add_action()") it doesn't do that anymore, it just removes the
> > devres action and frees associated memory, but it doesn't actually
> > release the GPIOs.
[...]
> Thanks for catching it, I queued it for v6.16-rc7.
Yeah, I used the release function in parameter, but not changed the call.
Thanks for a good catch!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-07-16 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 16:00 André Draszik
2025-07-15 16:39 ` André Draszik
2025-07-16 9:09 ` Bartosz Golaszewski
2025-07-16 9:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHdxRvJ6fCEiQ6Rn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andre.draszik@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®