From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B631248F7F for ; Thu, 17 Jul 2025 11:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752750827; cv=none; b=MFdlv7yuOtaV+uErk1Un6gHaXcKaD9n0T4V3cFKWhbQkh5mzNC1zReLSHQYdJttjoZyaQiskTB7yhZ+mGkHcLIw1HYPZVEZMWPyuogcZHPaZ0BmFy+OWPt6O2VjbUo98d7K5GdefD9kpSnQoJBisev5rFVcl0W3GK7oQzUzgldE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752750827; c=relaxed/simple; bh=8BEpr1buf3sugXNSK4wSx0vYzrS29Wqh55cQMzLzVC0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CYs1+QSD0c+8+J03vRtLEnvKcxzd0y7YDXmCiaDsatDawC6giTLSCz0JCrevhQSikWa9xLV63ALujlW78/VWGxe9h6/x8rg/+VkGqgfygk43lbWPBmGPUMcAMEsc2Gaskk1oWsAyuI3Pogy0no0TSbYFMvkDA8p9aXU6swJp8Ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Qhin5PUK; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qhin5PUK" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-aec5a714ae9so49064266b.3 for ; Thu, 17 Jul 2025 04:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752750824; x=1753355624; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vOehkU9WNuG64pnlROhzfrP3AIYNO0QBlG+TsOM5T5Q=; b=Qhin5PUKzVMtGVo4rh8f598elbDyqjwm+VnOTC31NXT8XD8WRdwn0AE5dTa8gkZQIe qw5A5qy3mLFvlQ2Ja1gHfREovdMC+XXFNziXzjHheTv+K42cBXUc7MVwqwfsj4U0nKKH A0gIiiYfPIscwwgMsggMm/n2mT74mfxyiwcx0JyKD1pitwEcWIY4xAJ+WE8/liBal+he oepi1BB5Km6RHvjFT3XKNF201FdBTZVkbfO3vswrM9qXiwkQkmHeMmsokhhitFkPcCCc 3o/YLaeezxvH8+hukj7WpuqxkXKNWg0tHIyrO4eA6/DuaezbwNAnzXnpUb8rkDyjAdod aS3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752750824; x=1753355624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vOehkU9WNuG64pnlROhzfrP3AIYNO0QBlG+TsOM5T5Q=; b=hnOS7INgTP2hM9pWisSLgwsGmac7UJqgjoD17uc2HMh9Sb/fnPEKqTF7Ln1pFf2ZIQ xHmiAv5ZN97nDmzCQOItpOdHjg6VhzEqBfRz7A330FjnSYQL0yYQOf1DbHzkCDriEB/H RrTVoOv7arl1W40oECR0cS8/qV66+kM2Gjd8h1pj5JZ3XmXyy+Y3oKoJAUAfsc5/ureB sEZa56OCiWs8P13O5LH2AZusE/pmG8iFMKui9FfyDQOSW3K5p7NX0hKjbzTTI7WVkitO wOSg9fu1TiSVvlRpwGKkRP6Zph706QLhIz+yj3tZyNW0d64vsSni7WIodV0Co7RJUI4T WRLA== X-Forwarded-Encrypted: i=1; AJvYcCWNKBWl/a6ePWCKQi+GnFEdyMpBIHRNcHymWBGKjGriYnACPcYRZUyw3yxGPn2geYTbpgmC7cSEzQtFxpI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3C4VbSkCn7b6QES7g3oOEjbSo3njOsOyeJEWFvk/6dQ7AM/DQ /xJWHin5Rc/J8g716VCmq8JtuIP6EhybKpYcTQGPE1/OrKbcMSQDxzQ4mUmCDnsLHqw= X-Gm-Gg: ASbGncs7d5sqfznMe6T+GRbg0iSapUYQRpGYosBSGhAKc+XnOVlINc3wAKe+Wzogi16 YVl8WxR3fSfUSNNgjzrOZ0hB7bcWABO4ajrhLgBEkM4mRmd466ibWp+o5+e2VBW+oUnLx5KipnO ilO/eWgjdwdDLZo7ZOGhjI8dg/f8qfIuZNYHD/sSvdWr+e1IPh9JLdfoXe44+HbQYk/fWoU3C0M 4naKiVtGWQ9kZlQoz8efEtpUZsbXzpTgstucpM+mivS02xp0QnXym15HJrxE9wH4it/sKu9iPw+ eFrq9Ioh9eqdlJGAscKsW2LWW3pHtsWt6VAxCOQBNOCwwR9PFdDpzdobHcGDPvoUtDglMS4BYAd pP5aG0YZMLZwNk8C56S8= X-Google-Smtp-Source: AGHT+IFndH4r5ylfIpMZuhJEN+t6RmbGJp26noeWsbrPyFdZ+6+r7xmc66l1gSyOJK7aFAE6hnyIZA== X-Received: by 2002:a17:907:1c1e:b0:ae2:60ba:da91 with SMTP id a640c23a62f3a-ae9c99872f5mr670778366b.15.1752750823783; Thu, 17 Jul 2025 04:13:43 -0700 (PDT) Received: from linaro.org ([82.79.186.23]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e8294b6bsm1350689266b.130.2025.07.17.04.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 04:13:42 -0700 (PDT) Date: Thu, 17 Jul 2025 14:13:41 +0300 From: Abel Vesa To: Pankaj Patil Cc: andersson@kernel.org, linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, quic_rjendra@quicinc.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] pinctrl: qcom: Add glymur pinctrl driver Message-ID: References: <20250716150822.4039250-1-pankaj.patil@oss.qualcomm.com> <20250716150822.4039250-3-pankaj.patil@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250716150822.4039250-3-pankaj.patil@oss.qualcomm.com> On 25-07-16 20:38:22, Pankaj Patil wrote: > Add TLMM pinctrl driver to support pin configuration with pinctrl > framework for Glymur SoC. > > Signed-off-by: Pankaj Patil > --- > drivers/pinctrl/qcom/Kconfig.msm | 10 + > drivers/pinctrl/qcom/Makefile | 1 + > drivers/pinctrl/qcom/pinctrl-glymur.c | 1782 +++++++++++++++++++++++++ > 3 files changed, 1793 insertions(+) > create mode 100644 drivers/pinctrl/qcom/pinctrl-glymur.c > [...] > diff --git a/drivers/pinctrl/qcom/pinctrl-glymur.c b/drivers/pinctrl/qcom/pinctrl-glymur.c > new file mode 100644 > index 000000000000..dc1b822538fe > --- /dev/null > +++ b/drivers/pinctrl/qcom/pinctrl-glymur.c > @@ -0,0 +1,1782 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2025 Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include Drop this one. > +#include > +#include And this one. > + > +#include "pinctrl-msm.h" > + [...] > + MSM_PIN_FUNCTION(usb2_tmu), > + MSM_PIN_FUNCTION(vsense_trigger_mirnat), > + MSM_PIN_FUNCTION(wcn_sw), > + MSM_PIN_FUNCTION(wcn_sw_ctrl), > +}; > + > +/* Every pin is maintained as a single group, and missing or non-existing pin > + * would be maintained as dummy group to synchronize pin group index with > + * pin descriptor registered with pinctrl core. > + * Clients would not be able to request these dummy pin groups. > + */ This comment style would be good for drivers/net, but not here. So add another comment line before "Every pin", like so: /* * Every pin is ... With the above addressed: Reviewed-by: Abel Vesa