From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFAA32FD5AD; Thu, 17 Jul 2025 17:06:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752771971; cv=none; b=FoRzRGsPyrIby6ACqDeQkczE3sMhbTxeFtoZLbtNzbrwShUPJj3Cp3bZiw0kV7vPITh0xAYUUTMlgpwCDvuyyf05+1D8OTangv720Gxh/fjmbwiLpScg2I9+1P64rLvao8zhQQiUnLeN6ePDLoO4raBCDSZY8NtEw2tFt2sQDaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752771971; c=relaxed/simple; bh=t1DK4l7l6P0SZg/OzJJPzKirYKNAZ7sCpI7tcRykSY4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VJz4I4rxaS15iSIwiXuoXjRVnoGRgeKE7RQ7v/7qJh0hGN2K0m5UTFFPPmT8G2TA0Q0rEhawtt3JSMlaesOf94n15eSEpPi6UgT38EnwnB9SxNAVoF06sTk7oY57S5HckP257hrWhRnmKCYayaoaVzXsbol/fAd7EYQzwUAUtG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p+wK3GFJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p+wK3GFJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6105EC4CEE3; Thu, 17 Jul 2025 17:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752771971; bh=t1DK4l7l6P0SZg/OzJJPzKirYKNAZ7sCpI7tcRykSY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p+wK3GFJ0pCHEPfr34xe47yY7BwT73tdLh5GE1jgQpi7eFsTemXN5U55sSEDvXpXM zH4HDARWBwYsR0XKugQ5FxAS/w5Rp6Uhy0dLLT08MT1bW1HWLZ/3U00bkadvLZ4RYS uZNeg4hlbagzoMaTwy9fMe0JZ94dsoypFytluYqlZZmCW5RFpmdyoVquOEuGn43DBQ COT8DewFLpKsm1/vDvLPdT1PouztO7+keoggnHUzCoA+PyErVArsSxODLs1dULszLl 9lIQRKmfNCZHxIXAdFEGzTWPvLDSBWAGi4wHaSdW69DVNQHuqKxdOYoPe+ocqoDBT9 SjaS1BOIK79OA== Date: Thu, 17 Jul 2025 07:06:10 -1000 From: Tejun Heo To: Chen Ridong Cc: Michal =?iso-8859-1?Q?Koutn=FD?= , Tiffany Yang , linux-kernel@vger.kernel.org, John Stultz , Thomas Gleixner , Stephen Boyd , Anna-Maria Behnsen , Frederic Weisbecker , Johannes Weiner , "Rafael J. Wysocki" , Pavel Machek , Roman Gushchin , Chen Ridong , kernel-team@android.com, Jonathan Corbet , cgroups@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC PATCH v2] cgroup: Track time in cgroup v2 freezer Message-ID: References: <20250714050008.2167786-2-ynaffit@google.com> <5rm53pnhpdeqljxqywh26gffh6vlyb5j5s6pzxhv52odhkl4fm@o6p7daoponsn> <6c9278b7-4eb4-4b47-b61a-a5bcc7e558b0@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c9278b7-4eb4-4b47-b61a-a5bcc7e558b0@huaweicloud.com> On Thu, Jul 17, 2025 at 09:52:38PM +0800, Chen Ridong wrote: > > With the given implementation (and use scenario), this'd better exposed > > in > > cgroup.freeze.stat.local > > > > Would it be possible to add this field to either cgroup.event or cgroup.stat? > Since the frozen status is already tracked in cgroup.event, this placement would maintain better > cohesion with existing metrics. > > This is just a suggestion. Yeah, given that the freezer is an integral part of cgroup core, using cgroup.stat[.local] probably makes more sense. Thanks. -- tejun