From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A0261C5F37 for ; Fri, 18 Jul 2025 14:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752850430; cv=none; b=rMC+zD/04qsC99AH8OwujFout4qKH5HPoy4vvbwjbuf6G1Slw1siMN26Cw6TKhAZoHoIwlJJfrPZnF+/xLrFjhcqsH0Q5/0llfsG7RQ/yyuEPfBpKpyE/tWAaxKYXgEB6UGXJ1aC6zwO5ZdVUpf3aC42JlT3BnVk8Gbo7On+w1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752850430; c=relaxed/simple; bh=mN3hzgJiNNPNWOhTNaA5bwuVe2pOkU891xX3VE06RGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VXSX6oEx0ON26zyTABrKBNBHTBOe8L7P9RD97v33ggD0un6SE9rN4zx6RmuRR1YHRzDoBaor7Ur1OSJFB1rarZ50CDDRb5xKGs9zkE2qFizEs8RZ/bcypn2hdnjxMJF7Jt35ua1Dz7AfmZKu5LFIHUsKDozfsdArzejv6tymf9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DpiZCNOv; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DpiZCNOv" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a531fcaa05so980367f8f.3 for ; Fri, 18 Jul 2025 07:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752850427; x=1753455227; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cRq4mZGW6hHwIgirPnFC0Ellx4rYs15LC6saX2uSxGU=; b=DpiZCNOvhZvyMJVGLNNEhZFz8PHOXuVCCTQ6nFW1m4TxhGl28B1880wvU8aa2150oe VqVXSvYliamqWRqKSpzhnjgG2uVcqBmJltIifj+48weUlnNx+AAj/rJX6q/BNeMFqgwM Nk2ilRx8XxoewyrbBesIhnO2VJRRbvu2bYhSosN+ktzgMVfEVak3YKdynRVqlSGm/oJ5 Py2/mmX/R0NtMhQvCHJLZENlyCO5ojQwOGFiJc8rAnzxY2LnnWma2Lf/kI/zINXR6jpO jagHkQzOoemjsjI4Sxo43VKJVaqDRAKdPw2SksrfBGeKbbOdDb8JgOyQaIo1IjjlxZYE hmXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752850427; x=1753455227; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cRq4mZGW6hHwIgirPnFC0Ellx4rYs15LC6saX2uSxGU=; b=S37EWkU/HqerBrIVHviHv8+Is29cS8NcV5MHzvp67+ViEYQ8h3k+VDfyn6/R9BHy3G 9GKC0gnzEuxOkYaCZmtAAu1YeZ6w71izV/kDl1qDzNChhSze1nVo9jzw3ckytA7bT8l+ iJlTK+x/6rQkP+3YbuD+2xlBM+UDNlGPAwZBtvAaDa75TIYXs8+9/LsLOg46DfZjZAny gYHdDluRrHgEvsr/Sg9HO2Nh0kU3yFv9i37CKbXR//sxiuhs/mOkj6ZZozHbN2rY0rg8 fV7pbdt+DMn25T0FQUgv5/aAFz/riXTiHSjB6OpMp0SLjFiyiJDfjF2t68deAsodcPhw fDmQ== X-Forwarded-Encrypted: i=1; AJvYcCWr/z3r8mx+d+EWyTyEHZfjZViSNlfN2SQ8DZS1Ag/4h54Apy4Ck5YgPhS9jX+MMl5z5Hn2ZD3mHYh6EWw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywczp3XLGct6wQ//zGP6CVpultSjYvbB1wvkOmd03OIIXnMHpNZ YvAyoTPSfR30WnXj5pY52xET4OrEulEMn5L8mVIrwSQ6RakxLsCdA+U4k7bG7+kjjQ== X-Gm-Gg: ASbGncsI8khcCmfTI2KXusg6XAY2xSNMZ97hFAZ5fD9TnsEZ2rgRqlm6WoscmdI1EqB z+dkOMhM/IeBeHPs7894TyFSclifonvwFtnAD+Jghzhz3Gu4fFwfRnF6UpySrqw6toyNP2VYuzI 1Yp1VJL4sjzXQNpMZEscZ/rZHf+kus9lFGIaQYRQ5nt4AULwq0i1icc9hQ/iZu9lvNpN8KzgBvv rB3JyW3/Osftxrj2/nwZMN49DpIsZs0UlvaLDC17sIP8dfKHiESNrkw0Qjg8Wc8QXwSHFbJ8gmB +fuS8+xGMbithqtOWTVhPyo6mpSo2Y8MRN6yPGXotoCZbEU90Z3+kA3eHwMUMyUDMmXdXl3+zYj rZf1rOJKXRBQnLMGgAd5VGAuLxFD94d7gl3l9Q2pikadRixtsX42tS8Q6pPsBg5GWcOZsBQ== X-Google-Smtp-Source: AGHT+IHRoLNQ/BOi8gPhfanYsriNie013yEjEncyuc0ze1Z2dpZlN67n7NZfnIUPQdvgGELPGcgEHQ== X-Received: by 2002:adf:e193:0:b0:3a3:7987:945f with SMTP id ffacd0b85a97d-3b60e5242a1mr10025699f8f.57.1752850427262; Fri, 18 Jul 2025 07:53:47 -0700 (PDT) Received: from google.com (120.142.205.35.bc.googleusercontent.com. [35.205.142.120]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4563f7c88a0sm11817035e9.2.2025.07.18.07.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 07:53:46 -0700 (PDT) Date: Fri, 18 Jul 2025 14:53:42 +0000 From: Keir Fraser To: Yao Yuan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Sean Christopherson , Eric Auger , Oliver Upton , Marc Zyngier , Will Deacon , Paolo Bonzini Subject: Re: [PATCH v2 2/4] KVM: arm64: vgic: Explicitly implement vgic_dist::ready ordering Message-ID: References: <20250716110737.2513665-1-keirf@google.com> <20250716110737.2513665-3-keirf@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 17, 2025 at 01:44:48PM +0800, Yao Yuan wrote: > On Wed, Jul 16, 2025 at 11:07:35AM +0800, Keir Fraser wrote: > > In preparation to remove synchronize_srcu() from MMIO registration, > > remove the distributor's dependency on this implicit barrier by > > direct acquire-release synchronization on the flag write and its > > lock-free check. > > > > Signed-off-by: Keir Fraser > > --- > > arch/arm64/kvm/vgic/vgic-init.c | 11 ++--------- > > 1 file changed, 2 insertions(+), 9 deletions(-) > > > > diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c > > index 502b65049703..bc83672e461b 100644 > > --- a/arch/arm64/kvm/vgic/vgic-init.c > > +++ b/arch/arm64/kvm/vgic/vgic-init.c > > @@ -567,7 +567,7 @@ int kvm_vgic_map_resources(struct kvm *kvm) > > gpa_t dist_base; > > int ret = 0; > > > > - if (likely(dist->ready)) > > + if (likely(smp_load_acquire(&dist->ready))) > > return 0; > > > > mutex_lock(&kvm->slots_lock); > > @@ -598,14 +598,7 @@ int kvm_vgic_map_resources(struct kvm *kvm) > > goto out_slots; > > } > > > > - /* > > - * kvm_io_bus_register_dev() guarantees all readers see the new MMIO > > - * registration before returning through synchronize_srcu(), which also > > - * implies a full memory barrier. As such, marking the distributor as > > - * 'ready' here is guaranteed to be ordered after all vCPUs having seen > > - * a completely configured distributor. > > - */ > > - dist->ready = true; > > + smp_store_release(&dist->ready, true); > > No need the store-release and load-acquire for replacing > synchronize_srcu_expedited() w/ call_srcu() IIUC: > > Tree SRCU on SMP: > call_srcu() > __call_srcu() > srcu_gp_start_if_needed() > __srcu_read_unlock_nmisafe() > #ifdef CONFIG_NEED_SRCU_NMI_SAFE > smp_mb__before_atomic() // __smp_mb() on ARM64, do nothing on x86. > #else > __srcu_read_unlock() > smp_mb() > #endif I don't think it's nice to depend on an implementation detail of kvm_io_bus_register_dev() and, transitively, on implementation details of call_srcu(). kvm_vgic_map_resources() isn't called that often and can afford its own synchronization. -- Keir > TINY SRCY on UP: > Should have no memory ordering issue on UP. > > > goto out_slots; > > out: > > mutex_unlock(&kvm->arch.config_lock); > > -- > > 2.50.0.727.gbf7dc18ff4-goog > >