From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: ip22zilog: Use platform device for probing
Date: Wed, 23 Jul 2025 14:32:05 +0200 [thread overview]
Message-ID: <aIDWRZXXfvaO_4xl@alpha.franken.de> (raw)
In-Reply-To: <2025072321-scorer-surfacing-1cdf@gregkh>
On Wed, Jul 23, 2025 at 02:02:43PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 23, 2025 at 01:58:23PM +0200, Thomas Bogendoerfer wrote:
> > +static int __init sgi_zilog_devinit(void)
> > +{
> > + struct resource res;
> > +
> > + memset(&res, 0, sizeof(res));
> > + res.start = HPC3_CHIP0_BASE + offsetof(struct hpc3_regs, rtcregs);
> > + res.end = res.start + sizeof(hpc3c0->rtcregs) - 1;
> > + res.flags = IORESOURCE_MEM;
> > +
> > + return platform_device_register(&zilog_device);
>
> Odd function, why do you need "res" at all if you do not do anything
> with it?
ouch, leftover from copy&paste... will remove in v2
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2025-07-23 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 11:58 Thomas Bogendoerfer
2025-07-23 12:02 ` Greg Kroah-Hartman
2025-07-23 12:32 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIDWRZXXfvaO_4xl@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®