From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AE881E1DFC for ; Wed, 23 Jul 2025 18:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753294380; cv=none; b=hPseMGXl4F17fanu/BJqbTgOsiyU9tavcgQbGjY4ZmMjwQkXyejdAKXnp5sy/En7QeMo9GaZI/YY6WSFIpSZi2HrCl9LE6VNSI+GX9gTpMvYinD4wKiQSMoDkjyJIJLGVh+efA8ckwE9dsfbfS+vzSrVH6EYn1ZqDFEbGwWw6Us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753294380; c=relaxed/simple; bh=IoJM5k8gu00K4USptc5OhMjR7OL/N6KUXNIuyJSq3/w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jHEb/VVaw3aGKrrBk1B1xQfIPn10LD33IhNf6aJ92vd6GBPl3/GLhdLUsgtFaLO6Ewo6zxtxJBfxXPnTeoeL53X+A4r33wihdWrg5+gWXFjyoTBruVTbdmcSF7E1s+zdTTWZaq1xUjD5LUhjiA4vbumiTyvvoLUodlw72nq1Neo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kerneltoast.com; spf=pass smtp.mailfrom=kerneltoast.com; dkim=pass (2048-bit key) header.d=kerneltoast.com header.i=@kerneltoast.com header.b=kecbuE/A; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kerneltoast.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kerneltoast.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kerneltoast.com header.i=@kerneltoast.com header.b="kecbuE/A" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-748d982e97cso238789b3a.1 for ; Wed, 23 Jul 2025 11:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kerneltoast.com; s=google; t=1753294378; x=1753899178; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KRBtTt4FaTOSTc+GWTfgDYuIZ/jxrCB5XixWzEejzWU=; b=kecbuE/A6GZwq7c02Tc+/vXRPPz2zQrj33eYJtUdG/1QHTkxPlfS/xVDkb6eK+mKwE wPzdZRZco1kmEXka7r+ghP2mee7uUkjuIkVyMlBCW1MuzCUHUGUw/+FgUyGpPZOoU8ji iEbu7Oq/PBiAVE8htxlHwsp7ybO4NMPXH2BH4DyJR9kAcidkYXoLT2abx6zAYC5WgOi3 vN4zOsGRCw4TDqHfknI+5Ol2OcPCbNiDxyORuLj6AQ1njQOfDbEN+GRXU/lfvuzc/gap Ddrp29qV6jGju7b33iZaHW1OhPN7uFiAt8IKa1QoUzxCiJzUXQARhHyuhbX32Cm/wzZt lEzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753294378; x=1753899178; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KRBtTt4FaTOSTc+GWTfgDYuIZ/jxrCB5XixWzEejzWU=; b=eSNTVlOqwRI8DjfVU8exhLzEkQVutOvgBq+VciN+24nsrNxlvu9Tu0DAvyPlSF1LeQ r1voxgNyso8riT3Qz5AVq3atsyvfav4T3EVuc1ofslzbWNWl7jMmsUha+uahgZpXKJYa sLen1t96hc3Yl1kXvhc+PY+noKhGfcdN2PDAjPtB3o6u/h+xkkdlVbP+A4oJWVV18U1d HHfkwKmyHq8Ubbjit2K1CJr6mWZlguETeaL0IBHg6NZlzjrrBeWmQ/0VOxcp9PVCKr1o pK0PN0yLKVE/fkAGEqCojnIXuy9cW8rIEN2fed9h6LM8ZvFViugzXzk50byMPFhbuP4G a4Xg== X-Forwarded-Encrypted: i=1; AJvYcCXwrY1JBNVnWmnXc6FeTnZatNLllZdo65Ps8pNj51xRrE1d8z8ra32jx4ZnfyPvlXq5dqsqSnURUPeIJzA=@vger.kernel.org X-Gm-Message-State: AOJu0YyeUcQ5DOH1qtRipobV173rHiOwq57CqHYWlewpJ1/4K9jD3jy1 hFkaydjGSVmxEKLcC354SM6LBDV27OVITJjHI0niTApCp1w3icakQDQElAqqT5QypmzR X-Gm-Gg: ASbGncu6pjft3Eef6+bAcQrxiBur+u1k0aVWdbhCLdGtTedLDh6Pc448Puh5CAowDmZ gy9B15cRqCBVij4ZdfibDCIBMCF0cptKDoG7auOfAB3y5JRIhhe3p6U5L0dtfJiEGG37Q70pdZi XX39u3qIt1kbtGZxWSl/wA3GqiL5pmP4HEtIAjSEsZj3CjPMVVQ37lTPRlIiFACc+xgThrarPeK QRTJ29ifMsQoeZ/R899pXHykq679pvYOwqiiZQbpTsswocNrzMlk+cYd1CvOcuc+Nl/HvSmoL2d AUs15wn9vOmDM/DXaCIhZGXz5/4f+FJBslDwYEpZ2KMHFej6t8XkDwH5PLSYbh8VQfa5noJ4BoS 9kK/u7V1PX5XPTvauucKvn+RntwVdjWcIlpY= X-Google-Smtp-Source: AGHT+IG8RlX8EaTNxnjrK8cBNiAzFaGbxNnOguyYkbJTZTChZrwDQdPD/l/h6iZ+WVo7VIPkC2HfZQ== X-Received: by 2002:a05:6a00:3e0b:b0:748:e38d:fed4 with SMTP id d2e1a72fcca58-76034a00040mr5466661b3a.6.1753294377675; Wed, 23 Jul 2025 11:12:57 -0700 (PDT) Received: from sultan-box ([142.147.89.218]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-759c89d6bf2sm9504248b3a.53.2025.07.23.11.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jul 2025 11:12:57 -0700 (PDT) Date: Wed, 23 Jul 2025 11:12:53 -0700 From: Sultan Alsawaf To: Bin Du Cc: mchehab@kernel.org, hverkuil@xs4all.nl, laurent.pinchart+renesas@ideasonboard.com, bryan.odonoghue@linaro.org, sakari.ailus@linux.intel.com, prabhakar.mahadev-lad.rj@bp.renesas.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, pratap.nirujogi@amd.com, benjamin.chan@amd.com, king.li@amd.com, gjorgji.rosikopulos@amd.com, Phil.Jawich@amd.com, Dominic.Antony@amd.com, Svetoslav.Stoilov@amd.com Subject: Re: [PATCH v2 0/8] Add AMD ISP4 driver Message-ID: References: <20250618091959.68293-1-Bin.Du@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618091959.68293-1-Bin.Du@amd.com> On Wed, Jun 18, 2025 at 05:19:51PM +0800, Bin Du wrote: > AMD ISP4 is the AMD image processing gen 4 which can be found in HP ZBook Ultra G1a 14 inch Mobile Workstation PC ( Ryzen AI Max 385) > (https://ubuntu.com/certified/202411-36043) > This patch series introduces the initial driver support for the AMD ISP4. > > Patch summary: > - Powers up/off and initializes ISP HW > - Configures and kicks off ISP FW > - Interacts with APP using standard V4l2 interface by video node > - Controls ISP HW and interacts with ISP FW to do image processing > - Support enum/set output image format and resolution > - Support queueing buffer from app and dequeueing ISP filled buffer to App > - Starts/stops sensor and mipi csi when camera App starts/stops streaming. > - It supports libcamera ver0.2 SimplePipeline > - It is verified on qv4l2, cheese and qcam > - It is verified together with following patches > platform/x86: Add AMD ISP platform config for OV05C10 (https://lore.kernel.org/all/20250514215623.522746-1-pratap.nirujogi@amd.com/) > media: i2c: Add OV05C10 camera sensor driver (https://lore.kernel.org/all/20250408221246.911508-1-pratap.nirujogi@amd.com/) > pinctrl: amd: isp411: Add amdisp GPIO pinctrl (https://github.com/torvalds/linux/commit/e97435ab09f3ad7b6a588dd7c4e45a96699bbb4a) > i2c: amd-isp: Add ISP i2c-designware driver (https://github.com/torvalds/linux/commit/d6263c468a761cd4c89887073614394ac48441e1) > drm/amd/amdgpu: Add GPIO resources required for amdisp (https://gitlab.freedesktop.org/agd5f/linux/-/commit/ad0f5966ed8297aa47b3184192b00b7379ae0758) Hi, I have the Ryzen AI MAX+ 395 SKU of the HP ZBook Ultra G1a 14. I cannot for the life of me get the webcam working under Linux. The webcam works under Windows so it's not a hardware issue. With this patchset and all of the patches you link here applied to 6.15, I get the following errors: [ 11.970038] amd_isp_i2c_designware amd_isp_i2c_designware: Unknown Synopsys component type: 0xffffffff [ 11.973162] amd_isp_i2c_designware amd_isp_i2c_designware: error -19: i2c_dw_probe failed With the old ispkernel code from February [1] applied on 6.15, the webcam indicator LED lights up but there's no image. I see these messages at boot: [ 9.449005] amd_isp_capture amd_isp_capture.1.auto: amdgpu: AMD ISP v4l2 device registered [ 9.489005] amd_isp_i2c_designware amd_isp_i2c_designware.2.auto: The OV05 sensor device is added to the ISP I2C bus [ 9.529012] amd_isp_i2c_designware amd_isp_i2c_designware.2.auto: timeout while trying to abort current transfer [ 9.554046] amd_isp_i2c_designware amd_isp_i2c_designware.2.auto: timeout in disabling adapter [ 9.554174] amd_isp_i2c_designware amd_isp_i2c_designware.2.auto: timeout while trying to abort current transfer [ 9.580022] amd_isp_i2c_designware amd_isp_i2c_designware.2.auto: timeout in disabling adapter And then the kernel crashes due to the same use-after-free issues I pointed out in my other email [2]. Any idea what's going on? [1] https://github.com/amd/Linux_ISP_Kernel/commit/c6d42584fbd0aa42cc91ecf16dc5c4f3dfea0bb4 [2] https://lore.kernel.org/r/aIEiJL83pOYO8lUJ@sultan-box Thanks, Sultan