mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	herculoxz <abhinav.ogl@gmail.com>,
	 linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,
	 linux-kernel@vger.kernel.org, bhelgaas@google.com,
	kwilczynski@kernel.org,  ojeda@kernel.org, alex.gaynor@gmail.com,
	boqun.feng@gmail.com,  gary@garyguo.net,
	bjorn3_gh@protonmail.com, lossin@kernel.org,
	 a.hindborg@kernel.org, tmgross@umich.edu
Subject: Re: [PATCH v2] rust: pci: Use explicit types in FFI callbacks
Date: Wed, 30 Jul 2025 07:56:50 +0000	[thread overview]
Message-ID: <aInQQqmDUZy40t3E@google.com> (raw)
In-Reply-To: <DBOMC68QGS76.2MYEXRE1I34VV@kernel.org>

On Tue, Jul 29, 2025 at 04:45:50PM +0200, Danilo Krummrich wrote:
> On Tue Jul 29, 2025 at 12:52 PM CEST, Miguel Ojeda wrote:
> > On Tue, Jul 29, 2025 at 12:30 PM herculoxz <abhinav.ogl@gmail.com> wrote:
> >>
> >> and improves ABI
> >> correctness when interfacing with C code.
> >
> > I think this still sounds like it is fixing an ABI issue -- I would
> > probably just remove that second sentence.
> 
> I agree, the types exported via prelude are the ones from kernel::ffi.
> 
> > (But no need for a v3 -- I think it can be fixed on apply unless
> > Danilo wants it).
> 
> Yeah, I can fix it up when applying the patch.
> 
> I also think the subject from v1, i.e. "use c_* types via kernel prelude", was
> better. This one is a bit misleading, the types in the FFI callbacks are already
> explicit.
> 
> Unless I hear otherwise, I will also revert the subject to the one of v1 when I
> apply the patch.

With the above changes:

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

  reply	other threads:[~2025-07-30  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 10:29 herculoxz
2025-07-29 10:52 ` Miguel Ojeda
2025-07-29 14:45   ` Danilo Krummrich
2025-07-30  7:56     ` Alice Ryhl [this message]
2025-07-29 16:35 ` Benno Lossin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aInQQqmDUZy40t3E@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=abhinav.ogl@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®