From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B37B1EE7B7 for ; Thu, 14 Aug 2025 14:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755182855; cv=none; b=QYgyVo2kk2ES46Opf/+/1iaZDVya9H3Hd4vRCKQYHXn711ATgA091/yIiICojNwU2LYtK6mRKtlC7RA6d2Jmp6giTU4xJVZujTW45UdYkTjDSngA8exx6hFsCwMKu6fykfATTR0+7Q+sfgoT0Zl9umSP6zywelmt5V0aq3z+EBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755182855; c=relaxed/simple; bh=FvgXrhJBchDglMj+MOf60VzgeTEvZMxp4caGmrdlrSg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rucm/pAbXQVOz5djSI00j0XOb3ki1yJyqsDBaBRk874QACBY9Ge4cRpyuIZYnfI9NGgd9iyOLyaa4OQEuuq7lYnnRX9bUGpZ49kXiCMCWvNULJodLapZMwYlTJoPl6SZAy+6xDCOG4hKWc6qB1Xz8wIT8RlptUf7bU0fqC1zFlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HY/USMe8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HY/USMe8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-45a1b05a59fso6693615e9.1 for ; Thu, 14 Aug 2025 07:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755182851; x=1755787651; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fZAqDF3XnpGXDPLOHIJz9Ec4YzJw9DgnDjI6cQZHRtQ=; b=HY/USMe8okexpKlUrKfbbNpKDfIBDuP4SY3bl8ibbi7B9RDgpRXy6KNgueAyLplG3+ sEwkSJmAx0UqXPcx62eb3cb4xj9jH7L7+lGAugRIRUaidmYWnAI1Tt8OSCTO98eFhqib GUJdhWjwnbyD0H93XEvuks8UpQf1KTaF1WdSSJNQOyyzFwzyvyGoqOHnmacNU718JCEF STbUIRVorrPja0LTfArPxONKhJJGV2EiMI8fARlKalaTo4o+8/s7Ds20TGXsOKM4B0hf Fl7cgygPWhmbxTYgWxA616xue3rW7/aZ0I1AXXKMuYJsAKuZBSrVTwLLHr5Zwyci1DFo /MTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755182851; x=1755787651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fZAqDF3XnpGXDPLOHIJz9Ec4YzJw9DgnDjI6cQZHRtQ=; b=IRG5ITUybmN3vQKtLxlQ+0BiuzMi41e7bDSRPH+TTb9ImF+lXnqbCy/HiFLzZeM8VS vhFmL9Ixkxtj5qePj3xRjjnJxmmN7S6tmz3VbLoQHOP8ZbYkI0Ir9/tSQLuYvJi+7ZGu 6TCQdT75WahvHqDrUzNIiUmKsJh0Uv4R4SJw0jTidVwm/umULOo49Q6crc3KgCkCND0r TssTf65fed7kGTRGCvHKI7BioEAaVAaCQn5qnqhthnrQjMdODt8m6hjWmXrB49C01j5q j/CRF3ZJ+zkfjFI6zryej/82qbxdv3Gg17yJyJDGE6dllCGEL6jsptEYzyDopgj1Kn9X 4Tmw== X-Forwarded-Encrypted: i=1; AJvYcCUSmKNG89bVwK8wY7U+gvnu11Gw8FmisB46lhOMTxG13wE5ubtQF736PDpDXJnuN2eSAbstr+fOI9i1dx4=@vger.kernel.org X-Gm-Message-State: AOJu0YxD6hgM9IzP/HkbpXmjx4uZIB45YxEQK/XVRd+9Fl2Os3sJu0bW 2+A/ba/pdWUITNaSQr0V0IX84nkK09QI7qrQo7Zn2vJhs/Ww2iVlPcUfgJjHKEOt+AQ= X-Gm-Gg: ASbGnctMgroer8V+xxmI38zqhd6diGsvYmZwVU2WRjSk0IvW5FZm10lTVf/1mKaujeZ x0IUzEoddddKxdFCbUxVsF2xZqnXedCuHJJRenaydlJRrGOqIPK42TwTlpy1t4bGOWO0FCSlSz7 KDT67d8EhCS8LrhUMee7F0ZLDbpoIQUmrzgc+ZQB4WRuwHDdRa9XwL0TmTIOMhs/KmW2oEVCfYK aaLruSdv9xubj4bsOy1n4dCQxd0uwp3K7Vx5j6LaPHI3F2uq3bmI/xFriw+FBsWD3Xoik4vseqR 9tu5BNCEpcRj3DUSZAhfu+X+7vkUht4Gzc9tpmmsCfioSYHPAT/L2lF7Mr6m8XSCbqT8Cwn3zfu 8h7FwwN7aCMk38fcK4qhIGyToDGCH9zXl X-Google-Smtp-Source: AGHT+IFhoWtHYN9QFJ0tW1CKBLQo56CkK5ldL2L/K77pZLZH70ja4pUfhvkjKDkzC2VxincZw5xstA== X-Received: by 2002:a05:600c:3b87:b0:456:2a9:f815 with SMTP id 5b1f17b1804b1-45a1b615307mr29980105e9.4.1755182851303; Thu, 14 Aug 2025 07:47:31 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:1e8b:1779:ed5:b6f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c74ad27sm25133535e9.18.2025.08.14.07.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 07:47:30 -0700 (PDT) Date: Thu, 14 Aug 2025 16:47:25 +0200 From: Stephan Gerhold To: Neil Armstrong , Christopher Obbard Cc: Johan Hovold , Douglas Anderson , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rui Miguel Silva , Abel Vesa , devicetree@vger.kernel.org Subject: Re: [PATCH v6 1/2] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller Message-ID: References: <20250731-wip-obbardc-qcom-t14s-oled-panel-v6-0-4782074104d1@linaro.org> <20250731-wip-obbardc-qcom-t14s-oled-panel-v6-1-4782074104d1@linaro.org> <536dd237-e668-4a88-ac2b-3bc88dca8a3e@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <536dd237-e668-4a88-ac2b-3bc88dca8a3e@linaro.org> On Thu, Aug 14, 2025 at 04:21:09PM +0200, Neil Armstrong wrote: > On 09/08/2025 00:28, Christopher Obbard wrote: > > On Mon, 4 Aug 2025 at 14:13, Johan Hovold wrote: > > > > > > On Thu, Jul 31, 2025 at 09:51:26PM +0100, Christopher Obbard wrote: > > > > The eDP controller has an HPD GPIO. Describe it in the device tree > > > > for the generic T14s model, as the HPD GPIO is used in both the > > > > OLED and LCD models which inherit this device tree. > > > > > > > @@ -5779,6 +5779,11 @@ tlmm: pinctrl@f100000 { > > > > gpio-ranges = <&tlmm 0 0 239>; > > > > wakeup-parent = <&pdc>; > > > > > > > > + edp_hpd_active: edp-hpd-active-state { > > > > > > The node name and label needs an index as this SoC has two edp hpd pins > > > as I already pointed out. > > > > Sure. After looking at the schematics this should be called > > edp0_hpd_active. I will fix this in the next revision. > > > > > > > > + pins = "gpio119"; > > > > + function = "edp0_hot"; > > > > > > And you also need to configure the bias somewhere as you should not rely > > > on the firmware having configured things for you (as I also pointed out > > > before). > > > > > > On my T14s the internal pull-up has been disabled. > > > > I am still unsure of what else needs to be set here. Can you help me > > with the correct settings? > > Just add bias-disable; > I sent a patch fixing this for all the X1 devices upstream earlier [1], so you could also just send v7 with just the second patch of your series. The bias-disable is really somewhat device-specific (what if there is no pull down on the device side and someone disconnects the panel entirely?), so I put it into each board DT separately like Johan requested on v5. We have the same for the PCIe pinctrl. Thanks, Stephan [1]: https://lore.kernel.org/linux-arm-msm/20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@linaro.org/T/