From: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
To: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
Cc: john.johansen@canonical.com, paul@paul-moore.com,
jmorris@namei.org, serge@hallyn.com, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah@kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v2] apparmor: Remove unused value
Date: Fri, 15 Aug 2025 09:40:18 +0530 [thread overview]
Message-ID: <aJ6zKriNeoM4B/km@bhairav-test.ee.iitb.ac.in> (raw)
In-Reply-To: <20250814165403.616195-1-chandramohan.explore@gmail.com>
On Thu, Aug 14, 2025 at 10:24:01PM +0530, Chandra Mohan Sundar wrote:
> The value "new" is being assigned to NULL but that statement does not
> have effect since "new" is being overwritten in the subsequent
> fallback case.
>
> Remove the unused value. This issue was reported by coverity static
> analyzer.
Hi Chandra. Do you have Coverity ID for this issue ?
Regards,
Akhilesh
>
> Fixes: a9eb185be84e9 ("apparmor: fix x_table_lookup when stacking is not the first entry")
> Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
> ---
> Changes since v1:
> Fixed the commit message and Fixes tag message formatting.
>
> security/apparmor/domain.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
> index 267da82afb14..9c0c7fa8de46 100644
> --- a/security/apparmor/domain.c
> +++ b/security/apparmor/domain.c
> @@ -592,7 +592,6 @@ static struct aa_label *x_to_label(struct aa_profile *profile,
> if (!new || **lookupname != '&')
> break;
> stack = new;
> - new = NULL;
> fallthrough; /* to X_NAME */
> case AA_X_NAME:
> if (xindex & AA_X_CHILD)
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2025-08-15 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 16:54 Chandra Mohan Sundar
2025-08-15 4:10 ` Akhilesh Patil [this message]
2025-08-15 6:34 ` Chandra Mohan Sundar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ6zKriNeoM4B/km@bhairav-test.ee.iitb.ac.in \
--to=akhilesh@ee.iitb.ac.in \
--cc=apparmor@lists.ubuntu.com \
--cc=chandramohan.explore@gmail.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®