From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BDEE24E4BD for ; Mon, 4 Aug 2025 10:54:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754304901; cv=none; b=KkmXBGiNvqmQrHa7ZLawaGqljEy+QqObwYdrjs88Yns0lw72HkST7tZxvMmxK2TS/nsXZTPeiAs7Aq7hmzw7alitwqU7ZjMya3cQuJXK0xW8miUhwyRf0PnpJ0xpXfqsgCdEdgCV1ISsXf+oeYL1btGcsqKGu8h0+ID/KU0pxdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754304901; c=relaxed/simple; bh=G+iM+Wpdl0pGgQeVVC7j3IxrRVcCkNicU048+veoUgY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KmPV4N4RZBH0Rd4mELJIBn+Qq1u/2R7PpY4naMcIxV3rNYTh1Pxubk6pa9+yS036XcqkYRy8YOzAhj3ioYw3iZpAGjddZgiIJTP7DjX5mmLtVQMKyO25b++WUr4GB3ZSEIo1yM9OYY0Z3ZtaS9QHidMEjLhH5n7ZeA/fCKfkfXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KjHAF4QH; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KjHAF4QH" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-458ba079338so12734525e9.1 for ; Mon, 04 Aug 2025 03:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1754304898; x=1754909698; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jTfwzKdFO4Billpr1agzWiIuczhIZbl+uk2TO52W1Ms=; b=KjHAF4QH0Xq3WzB1V6Lk1wY1jWkCezSxD8TSrXxdraxLoF1Gd6k9cHY5qG9HVc8s2c IcwIzxQVcKUEzprmR8GwS1sPZEZBgQ9HrZgl1qoH1Uu2GCcQ6hUq+XwZxs6Ij5J9GWmw 04sJF3TjdLl51ljDDm7qHuj/FRhO23HelnhTogfZ7ll6ruTpQA0RUctj8gW8Wd5dj0yu FMp4TV23n9ZHGp3MG6KZQvixhepVLCr9HtjCTvvHTSjvEy8rPX9l5BashWrS8vA0mNYg 0qHaZZrduEpS/BUx9ESYSNqTLleGW14jG3yyiTKKYp8cwuDIOg6C64kjN8CyLWQWmJtH soLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754304898; x=1754909698; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jTfwzKdFO4Billpr1agzWiIuczhIZbl+uk2TO52W1Ms=; b=nI2gf+lAykhOKMIo8v6VmYBVE9agRkVnMrKzic1j0z9RENtsArIEOrfu5nQasFQw88 iOblfrbsYQ9uOivM7u9d/LjwQYngx6k9WPcY6cqlxRwyDrZJKzWpo5v4Td0JgXsMzVhT 0230JBwWCCC/TDVBtsd3ZngIcjW+nexPdp5A+xq15ayqkFyH0cs1Bwhdc+D9VB3tHGVz YBEKb+ME2VydS/3ftedeTJczBmho+PVY0NVoHWk3uqVlb2+UcH5BFJal7c9HiGefS5sn dF62pO7kdTO3SlCJl0+h2lQr+qiVpFi6+o+x9gc9YnDMd5D2/9ADKfVuf9XiYfU9WN0d 33nA== X-Forwarded-Encrypted: i=1; AJvYcCUM3AerWdDJBGBpsBPjPICKIElWCIKJnQa5iGA6+z5EPv7O5eJUYXxoL6neaN4IemfX440bpalg4LeIQ3w=@vger.kernel.org X-Gm-Message-State: AOJu0YxNEWV67KCga7qJeOQSOYf0wMygMQ2wyVcyuLi075e/020R7SeQ hngGLa1JwTE/IhH69AQ3N6mJ0nD+t9W8KLyAJObLKar0+7RbURuGIe4NDZo/Pks/SYY= X-Gm-Gg: ASbGnctYzOp+IcpFaMfGEt0DRIJ9k6cTZ6dQa69UcqE3zjDf+WCzDyXYEkzbtZoXiQb vO+l+jA7PJbY6V9/O1T4fTdr+jDpp+d4tXDJbDpNpymibqDW0ulVzH0tdh1ql4r6sEhFkP+CcgW o424gNcCebbUV0cIQxNcRcXofejkbWFMeLrAdizrGK6IYdwGBWmIbedaR86XdpDeYrpBU8jcByl t+g4I13ZLs+LqKRs5hGQSpM+C8j/UWws2GqwM1324ABuJBzy7ueh9IUt8eMiAYGWRBMHcCRpfhx LDx6d+vHUwnlawScCW0PHi8MeK5A6pjoe/nDns/sb/40soiD0pktJbiVbERncw8POQrtHKUSLlL AVhwLI9hOHzpzslo3vLrOUDb0nd0OHllQyPNBrNgjQigek/kgYweNBmWDHNIcqti42Cr/i9IpAS Sgypw5gq9cFw== X-Google-Smtp-Source: AGHT+IHolr1jpSS8jZ3V5wzzwBRxkUohemu1Nv4CGTNmDUpUc5jSaT3JjX0JSbIFj/1+2LYoFZrMMw== X-Received: by 2002:a05:600c:5246:b0:456:1281:f8dd with SMTP id 5b1f17b1804b1-458b5f190f6mr71240945e9.12.1754304898475; Mon, 04 Aug 2025 03:54:58 -0700 (PDT) Received: from localhost (dynamic-2a00-1028-8394-58e6-9e1a-64e5-71bf-cbcb.ipv6.o2.cz. [2a00:1028:8394:58e6:9e1a:64e5:71bf:cbcb]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b79c453d6esm15241180f8f.37.2025.08.04.03.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Aug 2025 03:54:58 -0700 (PDT) Date: Mon, 4 Aug 2025 12:54:57 +0200 From: Michal Hocko To: David Hildenbrand Cc: Eugen Hristev , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, andersson@kernel.org, pmladek@suse.com, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, corbet@lwn.net, mojha@qti.qualcomm.com, rostedt@goodmis.org, jonechou@google.com, tudor.ambarus@linaro.org Subject: Re: [RFC][PATCH v2 22/29] mm/numa: Register information into Kmemdump Message-ID: References: <20250724135512.518487-1-eugen.hristev@linaro.org> <20250724135512.518487-23-eugen.hristev@linaro.org> <751514db-9e03-4cf3-bd3e-124b201bdb94@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <751514db-9e03-4cf3-bd3e-124b201bdb94@redhat.com> On Wed 30-07-25 16:04:28, David Hildenbrand wrote: > On 30.07.25 15:57, Eugen Hristev wrote: [...] > > Yes, registering after is also an option. Initially this is how I > > designed the kmemdump API, I also had in mind to add a flag, but, after > > discussing with Thomas Gleixner, he came up with the macro wrapper idea > > here: > > https://lore.kernel.org/lkml/87ikkzpcup.ffs@tglx/ > > Do you think we can continue that discussion , or maybe start it here ? > > Yeah, I don't like that, but I can see how we ended up here. > > I also don't quite like the idea that we must encode here what to include in > a dump and what not ... > > For the vmcore we construct it at runtime in crash_save_vmcoreinfo_init(), > where we e.g., have > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > Could we similar have some place where we construct what to dump similarly, > just not using the current values, but the memory ranges? All those symbols are part of kallsyms, right? Can we just use kallsyms infrastructure and a list of symbols to get what we need from there? In other words the list of symbols to be completely external to the code that is defining them? -- Michal Hocko SUSE Labs