Re: [PATCH v6 1/4] dt-bindings: clock: ipq5424-apss-clk: Add ipq5424 apss clock controller

[Varadarajan Narayanan <quic_varada@quicinc.com>]

On Wed, Aug 06, 2025 at 01:47:34PM +0200, Krzysztof Kozlowski wrote:
> On 06/08/2025 13:28, Varadarajan Narayanan wrote:
> > From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> >
> > The CPU core in ipq5424 is clocked by a huayra PLL with RCG support.
> > The RCG and PLL have a separate register space from the GCC.
> > Also the L3 cache has a separate pll and needs to be scaled along
> > with the CPU.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> This is oddly placed. Did you use b4 that it appeared here?

b4 places like this

	Co-developed-by: Md Sadre Alam <quic_mdalam@quicinc.com>
	Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
	Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
	[ Added interconnect related changes ]
	Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
	Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Since I haven't seen Reviewed-by coming after Signed-off-by, Was not
sure if my Signed-off-by should come before or after the Reviewed-by.
So, manually placed it there. If this is not ok, will use how b4's
placement itself and post the next version. Kindly, let me know.

Thanks
Varada

> > Co-developed-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > [ Added interconnect related changes ]
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> > v6: Add 'Reviewed-by: Krzysztof Kozlowski'
> >     Drop 'clock-names'
>
> Best regards,
> Krzysztof