From: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
To: benve@cisco.com, satishkh@cisco.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, neescoba@cisco.com, johndale@cisco.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
akhileshpatilvnit@gmail.com, skhan@linuxfoundation.org
Subject: [PATCH] enic: use string choice helpers to simplify dev_info arguments
Date: Mon, 11 Aug 2025 00:59:25 +0530 [thread overview]
Message-ID: <aJjzFb6c6OCGib2F@bhairav-test.ee.iitb.ac.in> (raw)
Use standard string choices helper str_yes_no() to simplify
arguments of dev_info() in enic_get_vnic_config().
Avoid hardcoded multiple use of same string constants by using
helper function achieving the same functionality.
Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
---
drivers/net/ethernet/cisco/enic/enic_res.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_res.c b/drivers/net/ethernet/cisco/enic/enic_res.c
index bbd3143ed73e..a09625d47edd 100644
--- a/drivers/net/ethernet/cisco/enic/enic_res.c
+++ b/drivers/net/ethernet/cisco/enic/enic_res.c
@@ -95,11 +95,11 @@ int enic_get_vnic_config(struct enic *enic)
dev_info(enic_get_dev(enic), "vNIC csum tx/rx %s/%s "
"tso/lro %s/%s rss %s intr mode %s type %s timer %d usec "
"loopback tag 0x%04x\n",
- ENIC_SETTING(enic, TXCSUM) ? "yes" : "no",
- ENIC_SETTING(enic, RXCSUM) ? "yes" : "no",
- ENIC_SETTING(enic, TSO) ? "yes" : "no",
- ENIC_SETTING(enic, LRO) ? "yes" : "no",
- ENIC_SETTING(enic, RSS) ? "yes" : "no",
+ str_yes_no(ENIC_SETTING(enic, TXCSUM)),
+ str_yes_no(ENIC_SETTING(enic, RXCSUM)),
+ str_yes_no(ENIC_SETTING(enic, TSO)),
+ str_yes_no(ENIC_SETTING(enic, LRO)),
+ str_yes_no(ENIC_SETTING(enic, RSS)),
c->intr_mode == VENET_INTR_MODE_INTX ? "INTx" :
c->intr_mode == VENET_INTR_MODE_MSI ? "MSI" :
c->intr_mode == VENET_INTR_MODE_ANY ? "any" :
--
2.34.1
next reply other threads:[~2025-08-10 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 19:29 Akhilesh Patil [this message]
2025-08-11 15:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJjzFb6c6OCGib2F@bhairav-test.ee.iitb.ac.in \
--to=akhilesh@ee.iitb.ac.in \
--cc=akhileshpatilvnit@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johndale@cisco.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®