From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EFDF3D561 for ; Mon, 11 Aug 2025 09:31:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754904663; cv=none; b=hp9rWMoowS/3hO1KmRCnIKZjPMCPr7DkCbwac0lG7VEiOoEw+6l5zuD9Ebyrk4cdNXaBcVpquPRdTSZNV9ZRKp29tr7foalgBrIH1kE7CzOnCOhZpEwrKLNiP2XZqjkPB2xQ1OQZIagLHiuRCbEyq0c3WZHhIF+LJ6OmqDR+RJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754904663; c=relaxed/simple; bh=U5T+MRdoU2ut8ZfAwliMu6fHkF1NxzjGtnfR/X+ITac=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SAqbWNY0pTXozHGkm9DQuYNH9EFN0R6pFbuWil4r5SEL1HaXJ0AX7fgbUQZMJ4I7FvQl9UKfisgn0AQdzcrWXci7/w6eqHwErkY8rxWSuj0lzyEWR9jxDn+KcgE9LQQiHz2RgfXWygkJ19yduBuBI2AHgVL1rKoNd4gTi3SwTYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05D07152B; Mon, 11 Aug 2025 02:30:52 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4899B3F5A1; Mon, 11 Aug 2025 02:30:59 -0700 (PDT) Date: Mon, 11 Aug 2025 10:30:51 +0100 From: Cristian Marussi To: Liao Yuanhong Cc: Sudeep Holla , Cristian Marussi , Jassi Brar , "open list:MAILBOX ARM MHUv3" , "moderated list:MAILBOX ARM MHUv3" Subject: Re: [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer Message-ID: References: <20250811082536.377896-1-liaoyuanhong@vivo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250811082536.377896-1-liaoyuanhong@vivo.com> On Mon, Aug 11, 2025 at 04:25:36PM +0800, Liao Yuanhong wrote: > Remove no_free_ptr() to ensure PTR_ERR() consistently retrieves the correct > error code. > Hi, > Signed-off-by: Liao Yuanhong > --- > drivers/mailbox/arm_mhuv3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/arm_mhuv3.c b/drivers/mailbox/arm_mhuv3.c > index b97e79a5870f..0910da67f8a1 100644 > --- a/drivers/mailbox/arm_mhuv3.c > +++ b/drivers/mailbox/arm_mhuv3.c > @@ -945,7 +945,7 @@ static irqreturn_t mhuv3_mbx_comb_interrupt(int irq, void *arg) > if (IS_ERR(data)) { > dev_err(dev, > "Failed to read in-band data. err:%ld\n", > - PTR_ERR(no_free_ptr(data))); > + PTR_ERR(data)); > goto rx_ack; Yes indeed the cleanup kfree helper takes care to skip any ERR_OR_NULL by itself...good catch, thanks for this. Acked-by: Cristian Marussi Thanks, Cristian