From: Carlos Llamas <cmllamas@google.com>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Christian Brauner" <christian@brauner.io>,
"Suren Baghdasaryan" <surenb@google.com>,
"Ben Hutchings" <benh@debian.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binder: Add missing module description
Date: Mon, 11 Aug 2025 17:36:20 +0000 [thread overview]
Message-ID: <aJoqFKYpWkDCiIJp@google.com> (raw)
In-Reply-To: <20250809073018.1720889-1-carnil@debian.org>
On Sat, Aug 09, 2025 at 09:30:18AM +0200, Salvatore Bonaccorso wrote:
> During build modpost issues a warning:
>
> # MODPOST Module.symvers
> ./scripts/mod/modpost -M -m -b -o Module.symvers -n -T modules.order vmlinux.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
>
> Fix this by adding the missing module description.
I'm not against having a description but binder is not tristate. Judging
from the 'binder_linux.o' this seems to be some OOT version? Otherwise,
I'm not sure you would be able to reproduce the warn.
>
> Reported-by: Ben Hutchings <benh@debian.org>
> Link: https://salsa.debian.org/kernel-team/linux/-/merge_requests/1587
> Suggested-by: Ben Hutchings <benh@debian.org>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> ---
> drivers/android/binder.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 312b462e349d..0c2e38ff3a3b 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -7090,3 +7090,4 @@ device_initcall(binder_init);
> #include "binder_trace.h"
>
> MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Android Binder IPC Driver");
> --
> 2.50.1
>
next prev parent reply other threads:[~2025-08-11 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 7:30 Salvatore Bonaccorso
2025-08-11 9:20 ` Alice Ryhl
2025-08-11 17:36 ` Carlos Llamas [this message]
2025-08-11 18:01 ` Salvatore Bonaccorso
2025-08-11 18:44 ` Carlos Llamas
2025-08-17 9:42 ` Greg Kroah-Hartman
2025-08-17 13:52 ` Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJoqFKYpWkDCiIJp@google.com \
--to=cmllamas@google.com \
--cc=arve@android.com \
--cc=benh@debian.org \
--cc=carnil@debian.org \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®