From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Saurabh Sengar <ssengar@linux.microsoft.com>,
Shradha Gupta <shradhagupta@linux.microsoft.com>,
Jonathan Cameron <Jonathan.Cameron@huwei.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Chen Wang <unicorn_wang@outlook.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>,
Han Gao <rabenda.cn@gmail.com>
Subject: Re: [PATCH 3/4] irqchip/sg2042-msi: Fix broken affinity setting
Date: Wed, 13 Aug 2025 15:54:40 +0300 [thread overview]
Message-ID: <aJyLEManKJ2P8HYV@smile.fi.intel.com> (raw)
In-Reply-To: <gnk4w7lmgvgwh3kdu3fn4c3frcyivkeukxrq63s223v4t7khcw@ft26odg7qtu6>
On Tue, Aug 12, 2025 at 06:37:35AM +0800, Inochi Amaoto wrote:
> On Mon, Aug 11, 2025 at 04:43:00PM +0200, Andy Shevchenko wrote:
> > On Thu, Aug 07, 2025 at 07:23:24PM +0800, Inochi Amaoto wrote:
> > > When using NVME on SG2044, the NVME always complains "I/O tag XXX
> > > (XXX) QID XX timeout, completion polled", which is caused by the
> > > broken handler of the sg2042-msi driver.
> > >
> > > As PLIC driver can only setting affinity when enabling, the sg2042-msi
> > > does not properly handled affinity setting previously and enable irq in
> > > an unexpected executing path.
> > >
> > > Since the PCI template domain supports irq_startup/irq_shutdown, set
> > > irq_chip_[startup/shutdown]_parent for irq_startup/irq_shutdown. So
> > > the irq can be started properly.
> >
> > > Fixes: e96b93a97c90 ("irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller")
> > > Reported-by: Han Gao <rabenda.cn@gmail.com>
> >
> > Closes ?
>
> I got a direct private email from Han, so I think there is no pulic
> Closes.
It's better to follow current practise (by at least some of the fix code
authors) to make this as a comment in the patch (text, that goes after '---'
but before actual diff).
No need to resent just for that, as you basically explained it here.
(but it seems we will have a new version anyway)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-13 12:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 11:23 [PATCH 0/4] " Inochi Amaoto
2025-08-07 11:23 ` [PATCH 1/4] genirq: Add irq_chip_(startup/shutdown)_parent Inochi Amaoto
2025-08-11 14:37 ` Thomas Gleixner
2025-08-11 22:32 ` Inochi Amaoto
2025-08-11 14:39 ` Andy Shevchenko
2025-08-07 11:23 ` [PATCH 2/4] PCI/MSI: Add startup/shutdown support for per device MSI[X] domains Inochi Amaoto
2025-08-07 16:25 ` Bjorn Helgaas
2025-08-07 23:18 ` Inochi Amaoto
2025-08-11 14:29 ` Thomas Gleixner
2025-08-07 11:23 ` [PATCH 3/4] irqchip/sg2042-msi: Fix broken affinity setting Inochi Amaoto
2025-08-11 14:43 ` Andy Shevchenko
2025-08-11 22:37 ` Inochi Amaoto
2025-08-13 12:54 ` Andy Shevchenko [this message]
2025-08-07 11:23 ` [PATCH 4/4] irqchip/sg2042-msi: Set MSI_FLAG_MULTI_PCI_MSI flags for SG2044 Inochi Amaoto
2025-08-11 14:33 ` Thomas Gleixner
2025-08-11 22:36 ` Inochi Amaoto
2025-08-11 23:15 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJyLEManKJ2P8HYV@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huwei.com \
--cc=bhelgaas@google.com \
--cc=dlan@gentoo.org \
--cc=inochiama@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=nicolinc@nvidia.com \
--cc=rabenda.cn@gmail.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®