From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Liao Yuanhong <liaoyuanhong@vivo.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rahul Tanwar <rahul.tanwar@linux.intel.com>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: equilibrium: Remove redundant semicolons
Date: Wed, 13 Aug 2025 16:17:46 +0300 [thread overview]
Message-ID: <aJyQevLQIs3Z1WVI@smile.fi.intel.com> (raw)
In-Reply-To: <20250812075444.8310-1-liaoyuanhong@vivo.com>
On Tue, Aug 12, 2025 at 03:54:44PM +0800, Liao Yuanhong wrote:
> Remove unnecessary semicolons.
While this is a good one
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> raw_spin_unlock_irqrestore(&pctl->lock, flags);
> *config = pinconf_to_config_packed(param, val);
> -;
> return 0;
...I would still keep a blank line before return. But I leave it to Linus to
decide or even amend when applying.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-13 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 7:54 Liao Yuanhong
2025-08-13 13:17 ` Andy Shevchenko [this message]
2025-08-19 11:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJyQevLQIs3Z1WVI@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=liaoyuanhong@vivo.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rahul.tanwar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®