Re: [PATCH] USB: serial: option: add SIMCom 8230C compositions

[Johan Hovold <johan@kernel.org>]

On Fri, Aug 08, 2025 at 11:03:01AM +0800, xiaowei.li@simcom.com wrote:
> 在 2025/8/8 1:27, Lars Melin 写道:
> > On 2025-08-07 14:52, xiaowei.li wrote:
> >> Add the following SIMCom 8230C compositions:
> >> 0x9071: tty (DM) + tty (NMEA) + tty (AT) + rmnet

> >> @@ -2097,6 +2097,12 @@ static const struct usb_device_id option_ids[] = {
> >>       { USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9003, 0xff) },    /* 
> >> Simcom SIM7500/SIM7600 MBIM mode */
> >>       { USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9011, 0xff),    /* Simcom 
> >> SIM7500/SIM7600 RNDIS mode */
> >>         .driver_info = RSVD(7) },
> >> +    { USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x907b, 0xff),
> >> +      .driver_info = RSVD(5) },
> >> +    { USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9078, 0xff),
> >> +      .driver_info = RSVD(5) },
> >> +    { USB_DEVICE(0x1e0e, 0x9071),
> >> +      .driver_info = RSVD(3) | RSVD(4) },

Please keep the entries sorted by VID/PID.

> >>       { USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9205, 0xff) },    /* 
> >> Simcom SIM7070/SIM7080/SIM7090 AT+ECM mode */
> >>       { USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9206, 0xff) },    /* 
> >> Simcom SIM7070/SIM7080/SIM7090 AT-only mode */
> >>       { USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_X060S_X200),

> > you are blacklisting interfaces 4 and 5 which are not present in your 
> > usb-devices listings and which are also not included in your interface 
> > function description.
> > You need to state the interface function which you can do as  .....tty 
> > (AT) + rmnet + {ADB} and also explain why the interface is hidden in
> > your usb-devices listings.

> Interfaces 4 (for 0x9071) and 5 (for 0x9078 and 0x907b) are reserved in 
> the option.c driver using RSVD() to prevent the option driver from 
> binding to the ADB interface.The ADB function is optional, so it was 
> hidden in the previous usb-devices listings.I have attached the new 
> usb-devices listings.

And please send a v2 with the updated commit message (e.g. usb-devices
output and SoB).

Johan