From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Arcari <darcari@redhat.com>
Cc: platform-driver-x86@vger.kernel.org,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Tero Kristo" <tero.kristo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel: power-domains validate domain in tpmi_cpu_online()
Date: Tue, 26 Aug 2025 22:20:40 +0300 [thread overview]
Message-ID: <aK4JCK8q-Kf3dS-w@pixelbook> (raw)
In-Reply-To: <20250826164331.1372856-1-darcari@redhat.com>
Tue, Aug 26, 2025 at 12:43:28PM -0400, David Arcari kirjoitti:
> Although tpmi_get_power_domain_mask() calls tpmi_domain_is_valid()
> prior to indexing tpmi_power_domain_mask[], tpmi_cpu_online() does
> not. In the case where a VM creates non-contiguous package ids the
> result can be memory corruption. This can be prevented by adding
> the same validation in tpmi_cpu_online().
>
> Fixes: 17ca2780458c ("platform/x86/intel: TPMI domain id and CPU mapping")
>
Shouldn't be blank lines in the tag block.
> Cc: Hans de Goede <hansg@kernel.org>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Dan Carpenter <dan.carpenter@linaro.org>
> Cc: David Arcari <darcari@redhat.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Tero Kristo <tero.kristo@linux.intel.com>
> Cc: linux-kernel@vger.kernel.org
Can you keep Cc list below '---' line? It will have the same effect on emails,
but reduce unneeded noise in the commit message. If one wants to retrieve this
it is available on lore archive.
> Signed-off-by: David Arcari <darcari@redhat.com>
> ---
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-26 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 16:43 David Arcari
2025-08-26 19:20 ` Andy Shevchenko [this message]
2025-08-26 20:26 ` srinivas pandruvada
2025-08-27 1:39 ` David Arcari
2025-08-27 11:49 ` srinivas pandruvada
2025-08-28 11:27 ` David Arcari
2025-08-28 11:54 ` srinivas pandruvada
2025-08-29 11:38 ` [PATCH v2] platform/x86/intel: power-domains: Use topology_logical_package_id() for package ID David Arcari
2025-08-29 12:19 ` srinivas pandruvada
2025-08-29 13:16 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK4JCK8q-Kf3dS-w@pixelbook \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=darcari@redhat.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tero.kristo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®