mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] docs: dt: writing-bindings: Add exception for clock-names
Date: Wed, 27 Aug 2025 11:23:00 -0400	[thread overview]
Message-ID: <aK8i1GTp2vPI8g2C@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250826235519.GA766501-robh@kernel.org>

On Tue, Aug 26, 2025 at 06:55:19PM -0500, Rob Herring wrote:
> On Tue, Aug 26, 2025 at 11:16:49AM -0400, Frank Li wrote:
> > Allow pattern like "pclk" and "hclk" as clock-names.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > https://lore.kernel.org/linux-i3c/20250625200451.GA2117971-robh@kernel.org/
> > ---
> >  Documentation/devicetree/bindings/writing-bindings.rst | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/writing-bindings.rst b/Documentation/devicetree/bindings/writing-bindings.rst
> > index 667816dd7d504..81f76ca57a394 100644
> > --- a/Documentation/devicetree/bindings/writing-bindings.rst
> > +++ b/Documentation/devicetree/bindings/writing-bindings.rst
> > @@ -97,7 +97,8 @@ Typical cases and caveats
> >    constraints (e.g. list of items).
> >
> >  - For names used in {clock,dma,interrupt,reset}-names, do not add any suffix,
> > -  e.g.: "tx" instead of "txirq" (for interrupt).
> > +  e.g.: "tx" instead of "txirq" (for interrupt). Except when only single letter
> > +  remains after removing the suffix, e.g., 'pclk', 'hclk'.
>
> It's more that the examples are the hardware names for the clocks than
> a single letter is too terse.

Yes, some hardware signal use name pclk, look like [X]clk name also from
hardware. How to document it here? It breaks "do not add any suffix" and
this name is allowed.

Some hardware use quite long name like ipg-clk. just need ipg in binding.

Frank
>
> Rob

      reply	other threads:[~2025-08-27 15:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 15:16 Frank Li
2025-08-26 23:55 ` Rob Herring
2025-08-27 15:23   ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aK8i1GTp2vPI8g2C@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®