From: Herbert Xu <herbert@gondor.apana.org.au>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Olivia Mackall <olivia@selenic.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
Arnd Bergmann <arnd@arndb.de>, Dragan Simic <dsimic@manjaro.org>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Daniel Golle <daniel@makrotopia.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Christian Marangi <ansuelsmth@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Markus Mayer <mmayer@broadcom.com>,
Lukas Bulwahn <lukas.bulwahn@redhat.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwrng: nomadik: add ARM_AMBA dependency
Date: Sat, 16 Aug 2025 17:34:21 +0800 [thread overview]
Message-ID: <aKBQnVHyaSjr4uQ2@gondor.apana.org.au> (raw)
In-Reply-To: <20250729152804.2411621-1-arnd@kernel.org>
On Tue, Jul 29, 2025 at 05:28:00PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing this driver is only possible when the AMBA bus driver is
> available in the kernel:
>
> x86_64-linux-ld: drivers/char/hw_random/nomadik-rng.o: in function `nmk_rng_remove':
> nomadik-rng.c:(.text+0x67): undefined reference to `amba_release_regions'
> x86_64-linux-ld: drivers/char/hw_random/nomadik-rng.o: in function `nmk_rng_probe':
> nomadik-rng.c:(.text+0xee): undefined reference to `amba_request_regions'
> x86_64-linux-ld: nomadik-rng.c:(.text+0x18d): undefined reference to `amba_release_regions'
>
> The was previously implied by the 'depends on ARCH_NOMADIK', but needs to be
> specified for the COMPILE_TEST case.
>
> Fixes: d5e93b3374e4 ("hwrng: Kconfig - Add helper dependency on COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/char/hw_random/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-08-16 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 15:28 Arnd Bergmann
2025-08-16 9:34 ` Herbert Xu [this message]
2025-10-06 8:23 ` Geert Uytterhoeven
2025-10-06 9:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKBQnVHyaSjr4uQ2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ansuelsmth@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=aurelien@aurel32.net \
--cc=cai.huoqing@linux.dev \
--cc=daniel@makrotopia.org \
--cc=dsimic@manjaro.org \
--cc=francesco.dolcini@toradex.com \
--cc=geert+renesas@glider.be \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=mmayer@broadcom.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®