mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: hannes@cmpxchg.org, mkoutny@suse.com, lizefan@huawei.com,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	lujialin4@huawei.com, chenridong@huawei.com, hdanton@sina.com
Subject: Re: [PATCH v3] cgroup: cgroup: drain specific subsystems when mounting/destroying a root
Date: Sat, 16 Aug 2025 06:16:18 -1000	[thread overview]
Message-ID: <aKCu0oLBbgxtKg_S@slm.duckdns.org> (raw)
In-Reply-To: <33990c53-5d7a-4f15-81b4-661c7bb96937@huaweicloud.com>

Hello,

On Sat, Aug 16, 2025 at 09:26:59AM +0800, Chen Ridong wrote:
...
> I've tested that adding a dedicated cgroup_offline_wq workqueue for CSS offline operations, which
> could resolve the current issue.
> 
> Going further, I propose we split cgroup_destroy_wq into three specialized workqueues to better
> match the destruction lifecycle:
> cgroup_offline_wq - Handles offline operations
> cgroup_release_wq - Manages resource release
> cgroup_free_wq - Performs final memory freeing
> 
> This explicit separation would clearly delineate responsibilities for each workqueue.
> 
> What are your thoughts on this approach, Tejun?

Yeah, sure. It'd also be helpful to note in a comment why separate
workqueues are used.

Thanks.

-- 
tejun

      reply	other threads:[~2025-08-16 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15  7:05 Chen Ridong
2025-08-15  7:31 ` Chen Ridong
2025-08-15 17:44 ` Tejun Heo
2025-08-16  1:26   ` Chen Ridong
2025-08-16 16:16     ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKCu0oLBbgxtKg_S@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=chenridong@huawei.com \
    --cc=chenridong@huaweicloud.com \
    --cc=hannes@cmpxchg.org \
    --cc=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=lujialin4@huawei.com \
    --cc=mkoutny@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®