From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8F4D430DD0E for ; Mon, 18 Aug 2025 09:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755508307; cv=none; b=TJkhdAf277Y0F2JQFk7rJhS+dmC+MulJm2O/tL9KvXo+448X7EZjV02RZMBtTqYxZJaWFwr9/8DR1paVhRSuuPzk3ff+wubR0tfxVV/s2DAzmlFxcb3xv+jZdpMtrZ8qJSboHlkr3mBNyqvExhBK29hFDYraZWPzwBKvivRS7Uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755508307; c=relaxed/simple; bh=gle12oxOtDoWNNjDbG8+S0dFyMPys4A83WkK/06gxHw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j0S9J8g/K7BUMzPgV803oqXm6sya1x6wGstC8IKWcyzgI1iPAHmVP8hDrYr/xfJLtCZPH7xt8SnPjfrF/RHY9BeoFjceqggZtoY02RJ8yKrsXDvLWxi8ME2MOHlrqypgJNMU86bGqeR4peJd5dC4HZyQKZ+3lnFSFeeqakpZWPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86D291424; Mon, 18 Aug 2025 02:11:35 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 19F0A3F58B; Mon, 18 Aug 2025 02:11:39 -0700 (PDT) Date: Mon, 18 Aug 2025 10:11:30 +0100 From: Mark Rutland To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Mark Brown , Ryan Roberts , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] arm64/sysreg: Update TCR_EL1 register Message-ID: References: <20250818045759.672408-1-anshuman.khandual@arm.com> <20250818045759.672408-2-anshuman.khandual@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250818045759.672408-2-anshuman.khandual@arm.com> On Mon, Aug 18, 2025 at 10:27:56AM +0530, Anshuman Khandual wrote: > Update TCR_EL1 register fields as per latest ARM ARM DDI 0487 7.B and while > here drop an explicit sysreg definition SYS_TCR_EL1 from sysreg.h, which is > now redundant. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Mark Brown > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/arm64/include/asm/sysreg.h | 2 -- > arch/arm64/tools/sysreg | 52 ++++++++++++++++++++++++++++----- > 2 files changed, 44 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index d5b5f2ae1afa..ad5c901af229 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -281,8 +281,6 @@ > #define SYS_RGSR_EL1 sys_reg(3, 0, 1, 0, 5) > #define SYS_GCR_EL1 sys_reg(3, 0, 1, 0, 6) > > -#define SYS_TCR_EL1 sys_reg(3, 0, 2, 0, 2) > - > #define SYS_APIAKEYLO_EL1 sys_reg(3, 0, 2, 1, 0) > #define SYS_APIAKEYHI_EL1 sys_reg(3, 0, 2, 1, 1) > #define SYS_APIBKEYLO_EL1 sys_reg(3, 0, 2, 1, 2) > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index 696ab1f32a67..4bdae8bb11dc 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -4756,17 +4756,53 @@ Field 37 TBI0 > Field 36 AS > Res0 35 > Field 34:32 IPS > -Field 31:30 TG1 > -Field 29:28 SH1 > -Field 27:26 ORGN1 > -Field 25:24 IRGN1 > +UnsignedEnum 31:30 TG1 > + 0b01 16K > + 0b10 4K > + 0b11 64K > +EndEnum This is clearly not an ordered set. This should just use Enum, not UnsignedEnum. Likewise for all the other cases below. Mark. > +UnsignedEnum 29:28 SH1 > + 0b00 NONE > + 0b10 OUTER > + 0b11 INNER > +EndEnum > +UnsignedEnum 27:26 ORGN1 > + 0b00 NC > + 0b01 WBWA > + 0b10 WT > + 0b11 WBnWA > +EndEnum > +UnsignedEnum 25:24 IRGN1 > + 0b00 NC > + 0b01 WBWA > + 0b10 WT > + 0b11 WBnWA > +EndEnum > Field 23 EPD1 > Field 22 A1 > Field 21:16 T1SZ > -Field 15:14 TG0 > -Field 13:12 SH0 > -Field 11:10 ORGN0 > -Field 9:8 IRGN0 > +UnsignedEnum 15:14 TG0 > + 0b00 4K > + 0b01 64K > + 0b10 16K > +EndEnum > +UnsignedEnum 13:12 SH0 > + 0b00 NONE > + 0b10 OUTER > + 0b11 INNER > +EndEnum > +UnsignedEnum 11:10 ORGN0 > + 0b00 NC > + 0b01 WBWA > + 0b10 WT > + 0b11 WBnWA > +EndEnum > +UnsignedEnum 9:8 IRGN0 > + 0b00 NC > + 0b01 WBWA > + 0b10 WT > + 0b11 WBnWA > +EndEnum > Field 7 EPD0 > Res0 6 > Field 5:0 T0SZ > -- > 2.25.1 > >