mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: vd55g1: Fix duster register address
Date: Mon, 18 Aug 2025 14:08:23 +0000	[thread overview]
Message-ID: <aKMz1xtvXvMLKUZ9@kekkonen.localdomain> (raw)
In-Reply-To: <20250818-vd55g1_fix_duster-v1-1-1b9d115dee87@foss.st.com>

Hi Benjamin,

On Mon, Aug 18, 2025 at 03:50:58PM +0200, Benjamin Mugnier wrote:
> The duster register needs to be disabled on test patterns. While the
> code is correctly doing so, the register address contained a typo, thus
> not disabling the duster correctly. Fix the typo.
> 
> Fixes: e56616d7b23c ("media: i2c: Add driver for ST VD55G1 camera sensor")
> 

Extra newline; I'll remove it while applying.

> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
>  drivers/media/i2c/vd55g1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index b89fff7e11f891dea04a0085a9e7aac841b6643d..cf35f73fdd1086c6d4d76f67c2b6e4cf66eadff8 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -66,7 +66,7 @@
>  #define VD55G1_REG_READOUT_CTRL				CCI_REG8(0x052e)
>  #define VD55G1_READOUT_CTRL_BIN_MODE_NORMAL		0
>  #define VD55G1_READOUT_CTRL_BIN_MODE_DIGITAL_X2		1
> -#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ea)
> +#define VD55G1_REG_DUSTER_CTRL				CCI_REG8(0x03ae)
>  #define VD55G1_DUSTER_ENABLE				BIT(0)
>  #define VD55G1_DUSTER_DISABLE				0
>  #define VD55G1_DUSTER_DYN_ENABLE			BIT(1)
> 

-- 
Regards,

Sakari Ailus

  reply	other threads:[~2025-08-18 14:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 13:50 Benjamin Mugnier
2025-08-18 14:08 ` Sakari Ailus [this message]
2025-08-18 14:52   ` Benjamin Mugnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKMz1xtvXvMLKUZ9@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®