mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Naveen N Rao <naveen@kernel.org>,
	mlevitsk@redhat.com,  Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Vasant Hegde <vasant.hegde@amd.com>,
	 Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [EARLY RFC] KVM: SVM: Enable AVIC by default from Zen 4
Date: Tue, 19 Aug 2025 16:54:29 -0700	[thread overview]
Message-ID: <aKUOtQvIAN5FC0MC@google.com> (raw)
In-Reply-To: <7cfe68c2-a84a-4416-a9ca-3bf5225190a1@maciej.szmigiero.name>

On Tue, Aug 19, 2025, Maciej S. Szmigiero wrote:
> On 18.07.2025 10:19, Naveen N Rao wrote:
> As you can see, currently AVIC works there even without force_avic=1 so why
> now hide it behind that parameter if errata #1235 is supposedly not present
> on Zen3?

Yeah, I'm aligned with keeping the current semantics for force_avic (and by
extension for avic), and I'm pretty sure Naveen is as well.

> Also, this platform is apparently confident enough that the AVIC silicon is
> working correctly there to expose it in CPUID - maybe because that's CPU
> stepping 2 instead of the initial 0?

My vote is still to only enable AVIC by default for Zen4+.  The story for Zen3
and earlier is just too messy.

      reply	other threads:[~2025-08-19 23:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 14:51 Naveen N Rao (AMD)
2025-06-26 17:34 ` mlevitsk
2025-06-26 18:44   ` Sean Christopherson
2025-06-26 19:14     ` mlevitsk
2025-06-26 20:43       ` Jim Mattson
2025-06-27  8:25       ` Naveen N Rao
2025-07-07 23:21         ` Sean Christopherson
2025-07-18  8:19           ` Naveen N Rao
2025-08-19 13:34             ` Maciej S. Szmigiero
2025-08-19 23:54               ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKUOtQvIAN5FC0MC@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=mlevitsk@redhat.com \
    --cc=naveen@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=vasant.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®