From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Masami Hiramatsu , Google" <mhiramat@kernel.org>
Cc: olsajiri@gmail.com, menglong8.dong@gmail.com,
mhiramat@kernel.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, hca@linux.ibm.com,
revest@chromium.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v5 1/4] fprobe: use rhltable for fprobe_ip_table
Date: Wed, 20 Aug 2025 10:05:02 +0800 [thread overview]
Message-ID: <aKUtTpAYaMdNgj2a@gondor.apana.org.au> (raw)
In-Reply-To: <20250819111111.40f443fd7faae8e92f93beaf@kernel.org>
Masami Hiramatsu , Google <mhiramat@kernel.org> wrote:
>
> Good catch! Hmm, previously we guaranteed that the find_first_fprobe_node()
> must be called under rcu read locked or fprobe_mutex locked, so that the
> node list should not be changed. But according to the comment of
> rhltable_lookup(), we need to lock the rcu_read_lock() around that.
Just as is the case for RCU in general, rcu read locks are unnecessary
for rhashtable if you already hold the write-side locks.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-08-20 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 2:46 [PATCH bpf-next v5 0/4] fprobe: use rhashtable " Menglong Dong
2025-08-17 2:46 ` [PATCH bpf-next v5 1/4] fprobe: use rhltable " Menglong Dong
2025-08-18 13:43 ` Jiri Olsa
2025-08-19 1:13 ` Menglong Dong
2025-08-19 2:11 ` Masami Hiramatsu
2025-08-19 2:26 ` Menglong Dong
2025-08-20 2:05 ` Herbert Xu [this message]
2025-08-17 2:46 ` [PATCH bpf-next v5 2/4] selftests/bpf: move get_ksyms and get_addrs to trace_helpers.c Menglong Dong
2025-08-17 2:46 ` [PATCH bpf-next v5 3/4] selftests/bpf: skip recursive functions for kprobe_multi Menglong Dong
2025-08-17 2:46 ` [PATCH bpf-next v5 4/4] selftests/bpf: add benchmark testing for kprobe-multi-all Menglong Dong
2025-08-19 1:48 ` [PATCH bpf-next v5 0/4] fprobe: use rhashtable for fprobe_ip_table Masami Hiramatsu
2025-08-19 2:01 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKUtTpAYaMdNgj2a@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bpf@vger.kernel.org \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=menglong8.dong@gmail.com \
--cc=mhiramat@kernel.org \
--cc=olsajiri@gmail.com \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®