mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Adrian Barnaś" <abarnas@google.com>
Cc: Hans de Goede <hansg@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Andy Shevchenko <andy@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: Whitespaces style cleanup in gdc.c
Date: Wed, 20 Aug 2025 16:04:10 +0300	[thread overview]
Message-ID: <aKXHypUfl00qE0yP@stanley.mountain> (raw)
In-Reply-To: <20250820124519.2287171-1-abarnas@google.com>

On Wed, Aug 20, 2025 at 12:45:19PM +0000, Adrian Barnaś wrote:
> NFC: This patch cleans up coding style whitespace issues

What does "NFC" mean in this context?  I only know it as the networking
protocol.

> in drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
> 
> Fixes include:
>  - removal of unnecessary line breaks
>  - correcting spacing around operators
>  - correcting spaces between types and names
> 
> Signed-off-by: Adrian Barnaś <abarnas@google.com>
> ---

[ snip ]

> @@ -85,8 +79,7 @@ void gdc_lut_convert_to_isp_format(const int in_lut[4][HRT_GDC_N],
>  	}
>  }
>  
> -int gdc_get_unity(
> -    const gdc_ID_t		ID)
> +int gdc_get_unity(const gdc_ID_t ID)
>  {
>  	assert(ID < N_GDC_ID);
>  	(void)ID;
> @@ -96,10 +89,8 @@ int gdc_get_unity(
>  /*
>   * Local function implementations
>   */
> -static inline void gdc_reg_store(
> -    const gdc_ID_t		ID,
> -    const unsigned int	reg,
> -    const hrt_data		value)
> +static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int	reg,
                                                                         ^^^^^^^
Replace this tab with a space.



> +				 const hrt_data value)
>  {
>  	ia_css_device_store_uint32(GDC_BASE[ID] + reg * sizeof(hrt_data), value);
>  	return;

regards,
dan carpenter

  reply	other threads:[~2025-08-20 13:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20 12:45 Adrian Barnaś
2025-08-20 13:04 ` Dan Carpenter [this message]
2025-08-20 13:05 ` Greg Kroah-Hartman
2025-08-20 13:07 ` Andy Shevchenko
     [not found]   ` <CAATBrPGqkuLrVhKi8aj-tugZNVMD3kqv5_v3WB=kJvt4FVtFzw@mail.gmail.com>
2025-08-21  6:37     ` Fwd: " Adrian Barnaś

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKXHypUfl00qE0yP@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=abarnas@google.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®