From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 658C3D531 for ; Wed, 20 Aug 2025 17:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755711725; cv=none; b=VbFULg0wysn17Td1wTyKzHyQERHM/T5hSYsma0oLvxIsm2ZjfAP55iz24QTghtXBQw6ERf4DD1KHSQXfw35MqPyjM31i3eERP1lE6cnk+ll3A4wFNKQevUHZ3j80MPhqqoUpMNfslGr4ksV8drnXVJfv5UHLItiMgQAkYOZI5Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755711725; c=relaxed/simple; bh=DkKU5FP5vCq391ejsMIE9BrqoApiOU1f9w6MNiv0UhY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rPASuBJB+njZwN98xM7rXvfw/0A/bui/0QqwmIei1Z3Cj+eeU4FSHlRstGCmIH3HG+lSLr8063aCBVlBOk6/mjh5ie2fm6HO+6PDg1QXbESpNmWHHOq3y7dTBERhn1TyMm9y0Myq5R4is2xeNeKHwYqBQIeOwdIW9IDc7aCu3Cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wbinvd.org; spf=pass smtp.mailfrom=wbinvd.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b=YMzxhnjN; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b="YMzxhnjN" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b47174aec0eso40108a12.2 for ; Wed, 20 Aug 2025 10:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wbinvd.org; s=wbinvd; t=1755711723; x=1756316523; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NzSUbaH+VOCVOUqJqJIjK5ALNlf0wJhYr4X2y+q08mw=; b=YMzxhnjNVj2RkpSCxterj+LTotgfd5ssBZeztOho/kkNiSsZdAEX5R5xdI/26JJhvx SF+ojZLlDmUyCYu7AdkL1vmZhfNX+cS/l8P3CA7n78eRoCJKHsTAYFocVIVRNHX5tdSY J/JBzFK1PJW1zGcR8rGQjGEpneBpf6Ohf/5SBVK0r9KhkflDZCkh1dbMa21dpBl6Kt3N kyUqbGdOv5c6AEagPagADREcnFdxmoE6PDbjkTC2jh0RVajtNAmTKyecioGx8ZGLB6ji gQR4obByCjeJWXBGaPk0XsBIYeoZ5ihTvFMB6J5NDBN+EbkqdZKZYtUZJBjTJoxTGiZJ aHfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755711723; x=1756316523; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NzSUbaH+VOCVOUqJqJIjK5ALNlf0wJhYr4X2y+q08mw=; b=NvIz5NmNrknFzFVpJO89yeKkbnruQEAz3SNSoYUxmt04sIUJ31Em/u0YvyqZ5p6p3s qzZO8JpChm+EQRKOQTyiLEps4f7F9C3nhKF2gePfHHeSg7nri15MKzC/fgrCaG/+C9HA dAq8l662eq2qq2crPNPcXYvqAs2eCMrcHIlIs/H/LnMmW/RigpKRob6PJsK5OUGal/yC vp3j0UhqbjgcCInJoA2f+rMhJheNWOD7dryJbEe/ISnrh0faoueUXZeFDAJSx0gypc2W 0o5ZYzsyRZBjUo4qS6RtqJfZhAoLMUo6/JcidZAnVEA6ny6bXSxSpIxbTTca4IuxRoOf 7V5A== X-Forwarded-Encrypted: i=1; AJvYcCU1J7EqeMjx2T46bNSZNPV0rNMB/mFeJVYT5zgqPiABCmSGjcTLgQfDo0AVObUz1ikTwlotC7LOSh7T+6w=@vger.kernel.org X-Gm-Message-State: AOJu0YxLdvbGiJjIKtmUumHDfRtPpNs2Z4EvcgdfoOk9ODQQ+0o/pdjl AZhFPapSAajAo/yhpP2wYiC2oxF3XLZNCIYcCCE+TMr881uuuhrX364MIparbKcLRwY= X-Gm-Gg: ASbGnctr/e1nzELpJkfoLeal87MyPHVv+XDTA3kEsrfmFYbtK+jyIc/WsVTs72xDKpI nQAKID/JaExr4fyv4DHaCmZKtQNdnnth63ifmiE6Cn1QabRbBcjwTmxCP5oot5p1+b8Bz8Y705P Q6frXCg9lDUAZifi0H6+fT199Cw53PzjYSJ+hDzoXnuiRmcaBQ23Wej9Fut9VoTpy992n0u1ZeS m1fdEoEsRXFyhvFK4rA86dYmRj5pV/cinQehhVi/t2pvuYEPv59dEU/9Xr+Pl+z5Dou+8XIFXNs XmvRoAKHSsFHkGUKrtcHZHboxSpB9ChkW4u6P3CTpmLVyz78NRrA4nQnWHyVByT5XU0WCKL4YgU fe9v9Q2BCt8OTIlBLq9BSUfUX X-Google-Smtp-Source: AGHT+IH4K4sRE7Fqgoy2HD4viykgQc0Xtxey922nomAwSvR23t0KFZi18mrd09Tt1Z+vQ9Ddj3lPkQ== X-Received: by 2002:a17:903:2ac5:b0:240:1bdc:afc3 with SMTP id d9443c01a7336-245ef2520ecmr42859755ad.44.1755711722603; Wed, 20 Aug 2025 10:42:02 -0700 (PDT) Received: from mozart.vkv.me ([192.184.167.117]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed339fa8sm32386365ad.20.2025.08.20.10.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 10:42:02 -0700 (PDT) Date: Wed, 20 Aug 2025 10:41:59 -0700 From: Calvin Owens To: Michal Schmidt Cc: netdev@vger.kernel.org, Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jedrzej Jagielski , Ivan Vecera , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] i40e: Prevent unwanted interface name changes Message-ID: References: <94d7d5c0bb4fc171154ccff36e85261a9f186923.1755661118.git.calvin@wbinvd.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wednesday 08/20 at 08:31 -0700, Calvin Owens wrote: > On Wednesday 08/20 at 08:42 +0200, Michal Schmidt wrote: > > On Wed, Aug 20, 2025 at 6:30 AM Calvin Owens wrote: > > > The same naming regression which was reported in ixgbe and fixed in > > > commit e67a0bc3ed4f ("ixgbe: prevent from unwanted interface name > > > changes") still exists in i40e. > > > > > > Fix i40e by setting the same flag, added in commit c5ec7f49b480 > > > ("devlink: let driver opt out of automatic phys_port_name generation"). > > > > > > Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") > > > > But this one's almost two years old. By now, there may be more users > > relying on the new name than on the old one. > > Michal > > Well, I was relying on the new ixgbe names, and I had to revert them > all in a bunch of configs yesterday after e67a0bc3ed4f :) And, even if it is e67a0bc3ed4f that introduced it, v6.7 was the first release with it. I strongly suspect most servers with i40e NICs running in the wild are running older kernels than that, and have not yet encountered the naming regression. But you probably have much better data about that than I do :)