From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>,
"hauke@hauke-m.de" <hauke@hauke-m.de>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arkadis@mellanox.com" <arkadis@mellanox.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"horms@kernel.org" <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"john@phrozen.org" <john@phrozen.org>,
"Stockmann, Lukas" <lukas.stockmann@siemens.com>,
"yweng@maxlinear.com" <yweng@maxlinear.com>,
"fchan@maxlinear.com" <fchan@maxlinear.com>,
"lxu@maxlinear.com" <lxu@maxlinear.com>,
"jpovazanec@maxlinear.com" <jpovazanec@maxlinear.com>,
"Schirm, Andreas" <andreas.schirm@siemens.com>,
"Christen, Peter" <peter.christen@siemens.com>,
"ajayaraman@maxlinear.com" <ajayaraman@maxlinear.com>,
"bxu@maxlinear.com" <bxu@maxlinear.com>,
"lrosu@maxlinear.com" <lrosu@maxlinear.com>
Subject: Re: [PATCH RFC net-next 12/23] net: dsa: lantiq_gswip: support 4k VLANs on API 2.2 or later
Date: Thu, 21 Aug 2025 18:43:53 +0100 [thread overview]
Message-ID: <aKdazKJftVzb0yVt@pidgin.makrotopia.org> (raw)
In-Reply-To: <dfb11982-5a7f-495c-8b25-aa1365ab8fe9@lunn.ch>
On Thu, Aug 21, 2025 at 07:03:35PM +0200, Andrew Lunn wrote:
> > > @@ -269,7 +270,8 @@ struct gswip_priv {
> > > struct dsa_switch *ds;
> > > struct device *dev;
> > > struct regmap *rcu_regmap;
> > > - struct gswip_vlan vlans[64];
> > > + struct gswip_vlan (*vlans)[];
> >
> > ... if this would be just "struct gswip_vlan *vlans;"?
>
> Could it be moved to the end of the structure and made into an
> flexible array?
I agree that it would be nice to get rid of the additional indirection,
I will implement it as flexible array when we arrive there (ie. after
both series of preparations have been merged).
prev parent reply other threads:[~2025-08-21 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 19:53 Daniel Golle
2025-08-21 16:40 ` Sverdlin, Alexander
2025-08-21 17:03 ` Andrew Lunn
2025-08-21 17:43 ` Daniel Golle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKdazKJftVzb0yVt@pidgin.makrotopia.org \
--to=daniel@makrotopia.org \
--cc=ajayaraman@maxlinear.com \
--cc=alexander.sverdlin@siemens.com \
--cc=andreas.schirm@siemens.com \
--cc=andrew@lunn.ch \
--cc=arkadis@mellanox.com \
--cc=bxu@maxlinear.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fchan@maxlinear.com \
--cc=hauke@hauke-m.de \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=jpovazanec@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lrosu@maxlinear.com \
--cc=lukas.stockmann@siemens.com \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=peter.christen@siemens.com \
--cc=yweng@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®