From: Dan Carpenter <dan.carpenter@linaro.org>
To: Brigham Campbell <me@brighamcampbell.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Douglas Anderson <dianders@chromium.org>,
Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
dri-devel <dri-devel-bounces@lists.freedesktop.org>
Subject: Re: [PATCH next] drm/panel: jdi-lpm102a188a: Fix error code in jdi_panel_prepare()
Date: Mon, 25 Aug 2025 08:50:46 +0300 [thread overview]
Message-ID: <aKv5tkJghj6DZQIB@stanley.mountain> (raw)
In-Reply-To: <DCAVWVJ990VS.255346CDNF1GK@brighamcampbell.com>
On Sun, Aug 24, 2025 at 12:54:41PM -0600, Brigham Campbell wrote:
> On Thu Aug 21, 2025 at 6:30 AM MDT, Dan Carpenter wrote:
> > If the mipi_dsi_dual() macro fails, the error code is stored in
> > dsi_ctx.accum_err. Propagate that error back to the caller instead
> > of returning success as the current code does.
> >
> > Fixes: a6adf47d30cc ("drm/panel: jdi-lpm102a188a: Fix bug and clean up driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> > ---
> > drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Good catch, Dan! Thank you for the patch. I'll try to be mindful of this
> kind of logic error in the future. Please let me know if you have other
> suggestions.
>
Heh. This is just static checker stuff. https://github.com/error27/smatch
Humans are expected to have mechanical attention to detail at the
same level as a computer. I just try to write the commit message out to
prove that I've looked at the code as well.
regards,
dan carpenter
next prev parent reply other threads:[~2025-08-25 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 12:30 Dan Carpenter
2025-08-21 14:50 ` Doug Anderson
2025-08-24 18:54 ` Brigham Campbell
2025-08-25 5:50 ` Dan Carpenter [this message]
2025-08-25 17:12 ` Brigham Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKv5tkJghj6DZQIB@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=dri-devel-bounces@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=me@brighamcampbell.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®