mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Carlo Caione <ccaione@baylibre.com>,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: firmware: meson-sm: fix compile-test default
Date: Mon, 8 Sep 2025 10:39:50 +0200	[thread overview]
Message-ID: <aL6WVp10hET2-fql@hovoldconsulting.com> (raw)
In-Reply-To: <4eacd669-9967-4ad7-a3a6-d124477100fe@linaro.org>

Hi Neil,

On Mon, Jul 28, 2025 at 05:42:00PM +0200, Neil Armstrong wrote:
> On 25/07/2025 09:54, Johan Hovold wrote:
> > Enabling compile testing should not enable every individual driver (we
> > have "allyesconfig" for that).
> > 
> > Fixes: 4a434abc40d2 ("firmware: meson-sm: enable build as module")
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >   drivers/firmware/meson/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/firmware/meson/Kconfig b/drivers/firmware/meson/Kconfig
> > index f2fdd3756648..179f5d46d8dd 100644
> > --- a/drivers/firmware/meson/Kconfig
> > +++ b/drivers/firmware/meson/Kconfig
> > @@ -5,7 +5,7 @@
> >   config MESON_SM
> >   	tristate "Amlogic Secure Monitor driver"
> >   	depends on ARCH_MESON || COMPILE_TEST
> > -	default y
> > +	default ARCH_MESON
> >   	depends on ARM64_4K_PAGES
> >   	help
> >   	  Say y here to enable the Amlogic secure monitor driver
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Could you pick this one up for 6.18 as well?

I noticed that there's a duplicate "firmware: " in Subject, perhaps you
can fix that up when applying?

Johan

  reply	other threads:[~2025-09-08  8:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25  7:54 Johan Hovold
2025-07-28 15:42 ` Neil Armstrong
2025-09-08  8:39   ` Johan Hovold [this message]
2025-09-10  7:41 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aL6WVp10hET2-fql@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=ccaione@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®