From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Thomas Huth <thuth@redhat.com>
Cc: "Maciej W . Rozycki" <macro@orcam.me.uk>,
linux-mips@vger.kernel.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mips: Replace __ASSEMBLY__ with __ASSEMBLER__ in the mips headers
Date: Fri, 29 Aug 2025 12:21:28 +0200 [thread overview]
Message-ID: <aLF_KF9yQ8Vm-Mf-@alpha.franken.de> (raw)
In-Reply-To: <20250804065629.55397-1-thuth@redhat.com>
On Mon, Aug 04, 2025 at 08:56:29AM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> While the GCC and Clang compilers already define __ASSEMBLER__
> automatically when compiling assembler code, __ASSEMBLY__ is a macro
> that only gets defined by the Makefiles in the kernel. Defining
> such a macro was necessary in the early days of the kernel, since GCC
> only started providing __ASSEMBLER__ since version 3.0 in 2000 (see
> https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=f8f769ea4e69 ).
> However, having two macros can be very confusing nowadays for the
> developers when switching between userspace and kernelspace coding,
> or when dealing with uapi headers that should use __ASSEMBLER__
> instead. So let's now standardize on the __ASSEMBLER__ macro that is
> provided by the compilers.
>
> This is almost a completely mechanical patch (done with a simple
> "sed -i" statement), with just one comment tweaked manually in
> arch/mips/include/asm/cpu.h (that was missing some underscores).
>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v3: Updated the patch description according to the suggestions of Maciej
>
> arch/mips/include/asm/addrspace.h | 4 +--
> arch/mips/include/asm/asm-eva.h | 6 ++--
> arch/mips/include/asm/asm.h | 8 ++---
> arch/mips/include/asm/bmips.h | 4 +--
> arch/mips/include/asm/cpu.h | 4 +--
> arch/mips/include/asm/dec/ecc.h | 2 +-
> arch/mips/include/asm/dec/interrupts.h | 4 +--
> arch/mips/include/asm/dec/kn01.h | 2 +-
> arch/mips/include/asm/dec/kn02.h | 2 +-
> arch/mips/include/asm/dec/kn02xa.h | 2 +-
> arch/mips/include/asm/eva.h | 4 +--
> arch/mips/include/asm/ftrace.h | 8 ++---
> arch/mips/include/asm/hazards.h | 4 +--
> arch/mips/include/asm/irqflags.h | 4 +--
> arch/mips/include/asm/jazz.h | 16 ++++-----
> arch/mips/include/asm/jump_label.h | 4 +--
> arch/mips/include/asm/linkage.h | 2 +-
> arch/mips/include/asm/mach-generic/spaces.h | 4 +--
> arch/mips/include/asm/mips-boards/bonito64.h | 4 +--
> arch/mips/include/asm/mipsmtregs.h | 6 ++--
> arch/mips/include/asm/mipsregs.h | 6 ++--
> arch/mips/include/asm/msa.h | 4 +--
> arch/mips/include/asm/pci/bridge.h | 4 +--
> arch/mips/include/asm/pm.h | 6 ++--
> arch/mips/include/asm/prefetch.h | 2 +-
> arch/mips/include/asm/regdef.h | 4 +--
> arch/mips/include/asm/sibyte/board.h | 4 +--
> arch/mips/include/asm/sibyte/sb1250.h | 2 +-
> arch/mips/include/asm/sibyte/sb1250_defs.h | 6 ++--
> arch/mips/include/asm/smp-cps.h | 6 ++--
> arch/mips/include/asm/sn/addrs.h | 18 +++++-----
> arch/mips/include/asm/sn/gda.h | 4 +--
> arch/mips/include/asm/sn/kldir.h | 4 +--
> arch/mips/include/asm/sn/klkernvars.h | 4 +--
> arch/mips/include/asm/sn/launch.h | 4 +--
> arch/mips/include/asm/sn/nmi.h | 8 ++---
> arch/mips/include/asm/sn/sn0/addrs.h | 14 ++++----
> arch/mips/include/asm/sn/sn0/hub.h | 2 +-
> arch/mips/include/asm/sn/sn0/hubio.h | 36 ++++++++++----------
> arch/mips/include/asm/sn/sn0/hubmd.h | 4 +--
> arch/mips/include/asm/sn/sn0/hubni.h | 6 ++--
> arch/mips/include/asm/sn/sn0/hubpi.h | 4 +--
> arch/mips/include/asm/sn/types.h | 2 +-
> arch/mips/include/asm/sync.h | 2 +-
> arch/mips/include/asm/thread_info.h | 4 +--
> arch/mips/include/asm/unistd.h | 4 +--
> arch/mips/include/asm/vdso/gettimeofday.h | 4 +--
> arch/mips/include/asm/vdso/processor.h | 4 +--
> arch/mips/include/asm/vdso/vdso.h | 4 +--
> arch/mips/include/asm/vdso/vsyscall.h | 4 +--
> arch/mips/include/asm/xtalk/xtalk.h | 4 +--
> arch/mips/include/asm/xtalk/xwidget.h | 4 +--
> drivers/soc/bcm/brcmstb/pm/pm.h | 2 +-
> 53 files changed, 142 insertions(+), 142 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2025-08-29 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 6:56 Thomas Huth
2025-08-29 10:21 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLF_KF9yQ8Vm-Mf-@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=philmd@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®