From: Frank Li <Frank.li@nxp.com>
To: Stanley Chu <stanley.chuys@gmail.com>
Cc: miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com
Subject: Re: [PATCH v2 2/2] i3c: master: svc: Recycle unused IBI slot
Date: Fri, 29 Aug 2025 10:58:35 -0400 [thread overview]
Message-ID: <aLHAGzrjooC65acL@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250829012309.3562585-3-yschu@nuvoton.com>
On Fri, Aug 29, 2025 at 09:23:09AM +0800, Stanley Chu wrote:
> In svc_i3c_master_handle_ibi(), an IBI slot is fetched from the pool
> to store the IBI payload. However, when an error condition is encountered,
> the function returns without recycling the IBI slot, resulting in an IBI
> slot leak.
>
> Fixes: c85e209b799f ("i3c: master: svc: fix ibi may not return mandatory data byte")
> Signed-off-by: Stanley Chu <yschu@nuvoton.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Changes since v1:
> * Add Fixes tag
> ---
> drivers/i3c/master/svc-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 8e7b4ab919e3..9641e66a4e5f 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -417,6 +417,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master,
> SVC_I3C_MSTATUS_COMPLETE(val), 0, 1000);
> if (ret) {
> dev_err(master->dev, "Timeout when polling for COMPLETE\n");
> + i3c_generic_ibi_recycle_slot(data->ibi_pool, slot);
> return ret;
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-08-29 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 1:23 [PATCH v2 0/2] i3c: master: svc: improve IBI handling Stanley Chu
2025-08-29 1:23 ` [PATCH v2 1/2] i3c: master: svc: Use manual response for IBI events Stanley Chu
2025-08-29 14:58 ` Frank Li
2025-08-29 1:23 ` [PATCH v2 2/2] i3c: master: svc: Recycle unused IBI slot Stanley Chu
2025-08-29 14:58 ` Frank Li [this message]
2025-09-14 20:54 ` [PATCH v2 0/2] i3c: master: svc: improve IBI handling Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLHAGzrjooC65acL@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=kwliu@nuvoton.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=stanley.chuys@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=yschu@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®