From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADB07322C87; Fri, 29 Aug 2025 16:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756483590; cv=none; b=TFYJiuyB7/F0lTptKA4vkn2b3lxVv/p0ZoMLDQLjXoRpylgLeFMYWPNMhObuOWuZwWDSNGGgxPcCE7H0nHjrafA6T6/xsAlfCqEY7Wicas74XoW3n+3+ub6VyFRFvRG4I4bG/+491NVqWGJ84GnWa2XibKDik9veWEN/VAfWXlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756483590; c=relaxed/simple; bh=LVZKd7XB5KhxjluvmFDIHuczLeLOOcpTEZSe92V8esA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KWx9CCN8fZE9Pa3fxLUVYA3+Udd+L+cwMuTnMnT2yRPHqnetYPJt1Nw2IFiAbb0n5FAGQYAWP9JSEJfRiTHtt4nhsG4NTXEuMFMyje0/1tEAOY+hUWICOUxpCs58SJQtsVLmHwACMsSVKc3Ng7uprz5pwEM6XPZDTBKwoANOczU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C2AD41BD0; Fri, 29 Aug 2025 09:06:19 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DB823F778; Fri, 29 Aug 2025 09:06:23 -0700 (PDT) Date: Fri, 29 Aug 2025 17:06:17 +0100 From: Mark Rutland To: Kees Cook , Kevin Brodsky Cc: Ard Biesheuvel , Catalin Marinas , Will Deacon , Oliver Upton , Anshuman Khandual , Yue Haibing , Marc Zyngier , Mark Brown , linux-arm-kernel@lists.infradead.org, Ryan Roberts , Shameer Kolothum , Joey Gouly , Yeoreum Yun , James Morse , Hardevsinh Palaniya , Andrew Morton , David Hildenbrand , Zhenhua Huang , Lorenzo Stoakes , Dev Jain , Yicong Yang , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] arm64: mm: Fix CFI failure due to kpti_ng_pgd_alloc function signature Message-ID: References: <20250829154913.work.943-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250829154913.work.943-kees@kernel.org> On Fri, Aug 29, 2025 at 08:49:21AM -0700, Kees Cook wrote: > Seen during KPTI initialization: > > CFI failure at create_kpti_ng_temp_pgd+0x124/0xce8 (target: kpti_ng_pgd_alloc+0x0/0x14; expected type: 0xd61b88b6) > > The call site is alloc_init_pud() at arch/arm64/mm/mmu.c: > > pud_phys = pgtable_alloc(TABLE_PUD); > > alloc_init_pud() has the prototype: > > static void alloc_init_pud(p4d_t *p4dp, unsigned long addr, unsigned long end, > phys_addr_t phys, pgprot_t prot, > phys_addr_t (*pgtable_alloc)(enum pgtable_type), > int flags) > > where the pgtable_alloc() prototype is declared. > > The target (kpti_ng_pgd_alloc) is used in arch/arm64/kernel/cpufeature.c: > > create_kpti_ng_temp_pgd(kpti_ng_temp_pgd, __pa(alloc), KPTI_NG_TEMP_VA, > PAGE_SIZE, PAGE_KERNEL, kpti_ng_pgd_alloc, 0); > > which is an alias for __create_pgd_mapping_locked() with prototype: > > extern __alias(__create_pgd_mapping_locked) > void create_kpti_ng_temp_pgd(pgd_t *pgdir, phys_addr_t phys, > unsigned long virt, > phys_addr_t size, pgprot_t prot, > phys_addr_t (*pgtable_alloc)(enum pgtable_type), > int flags); > > __create_pgd_mapping_locked() passes the function pointer down: > > __create_pgd_mapping_locked() -> alloc_init_p4d() -> alloc_init_pud() > > But the target function (kpti_ng_pgd_alloc) has the wrong signature: > > static phys_addr_t __init kpti_ng_pgd_alloc(int shift); > > The "int" should be "enum pgtable_type". > > To make "enum pgtable_type" available to cpufeature.c, move > enum pgtable_type definition from arch/arm64/mm/mmu.c to > arch/arm64/include/asm/mmu.h. > > Adjust kpti_ng_pgd_alloc to use "enum pgtable_type" instead of "int". > The function behavior remains identical (parameter is unused). > > Fixes: 47546a1912fc ("arm64: mm: install KPTI nG mappings with MMU enabled") That doesn't look right; that commit is from June 2022, and we only introduced enum pgtable_type in May 2025 in commit: c64f46ee13779616 ("arm64: mm: use enum to identify pgtable level instead of *_SHIFT") ... which landed in v6.16. AFAICT, that's the commit which broke things. The actual fix looks fine, though I suspect we should move more of this logic into mmu.c. Mark. > Signed-off-by: Kees Cook > --- > Cc: Ard Biesheuvel > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Oliver Upton > Cc: Anshuman Khandual > Cc: Yue Haibing > Cc: Mark Rutland > Cc: Marc Zyngier > Cc: Mark Brown > Cc: > --- > arch/arm64/include/asm/mmu.h | 7 +++++++ > arch/arm64/kernel/cpufeature.c | 5 +++-- > arch/arm64/mm/mmu.c | 7 ------- > 3 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h > index 6e8aa8e72601..49f1a810df16 100644 > --- a/arch/arm64/include/asm/mmu.h > +++ b/arch/arm64/include/asm/mmu.h > @@ -17,6 +17,13 @@ > #include > #include > > +enum pgtable_type { > + TABLE_PTE, > + TABLE_PMD, > + TABLE_PUD, > + TABLE_P4D, > +}; > + > typedef struct { > atomic64_t id; > #ifdef CONFIG_COMPAT > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 9ad065f15f1d..e49d142a281f 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -84,6 +84,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1945,11 +1946,11 @@ static bool has_pmuv3(const struct arm64_cpu_capabilities *entry, int scope) > extern > void create_kpti_ng_temp_pgd(pgd_t *pgdir, phys_addr_t phys, unsigned long virt, > phys_addr_t size, pgprot_t prot, > - phys_addr_t (*pgtable_alloc)(int), int flags); > + phys_addr_t (*pgtable_alloc)(enum pgtable_type), int flags); > > static phys_addr_t __initdata kpti_ng_temp_alloc; > > -static phys_addr_t __init kpti_ng_pgd_alloc(int shift) > +static phys_addr_t __init kpti_ng_pgd_alloc(enum pgtable_type type) > { > kpti_ng_temp_alloc -= PAGE_SIZE; > return kpti_ng_temp_alloc; > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 34e5d78af076..183801520740 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -47,13 +47,6 @@ > #define NO_CONT_MAPPINGS BIT(1) > #define NO_EXEC_MAPPINGS BIT(2) /* assumes FEAT_HPDS is not used */ > > -enum pgtable_type { > - TABLE_PTE, > - TABLE_PMD, > - TABLE_PUD, > - TABLE_P4D, > -}; > - > u64 kimage_voffset __ro_after_init; > EXPORT_SYMBOL(kimage_voffset); > > -- > 2.34.1 >