From: Javier Nieto <jgnieto@cs.stanford.edu>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: luiz.dentz@gmail.com, marcel@holtmann.org,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_h5: implement CRC data integrity
Date: Sun, 31 Aug 2025 19:20:14 -0700 [thread overview]
Message-ID: <aLUC3u3ZrF35nIb6@macbookair.lan> (raw)
In-Reply-To: <a261ed13-4c0b-43cf-b177-d33272626d25@molgen.mpg.de>
Dear Paul,
Thanks for the review!
On Wed, Aug 27, 2025 at 12:56:50PM +0200, Paul Menzel wrote:
> Any btmon trace?
The presence of CRC is limited to the H5 layer, so it is not visible on
btmon. However, I did advertise and connect to a few devices while
running btmon and everything worked and looked as normal. I also ensured
that CRC was being used by adding temporary debugging prints.
> I´d add the above to the proper commit message.
Should I resubmit the patch as v2?
> > static u8 h5_cfg_field(struct h5 *h5)
> > {
> > - /* Sliding window size (first 3 bits) */
> > - return h5->tx_win & 0x07;
> > + /* Sliding window size (first 3 bits) and CRC request (fifth bit). */
> > + return (h5->tx_win & 0x07) | 0x10;
>
> Could a macro be defined for the CRC request bit?
I thought about this, but decided against it since 0x10 is only used
here and in one other place. Also, the existing code does not define a
macro for the window size bits 0x07. I am not opposed to adding it if
someone feels strongly about it though.
> The diff looks good. Feel free to carry:
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul
I see that my patch fails a few test cases because it fails to link
crc-ccitt. Do you know whether this is a problem with my patch or the
test environment and where the code for the tests is found?
Thanks again for your feedback.
Javier
next prev parent reply other threads:[~2025-09-01 2:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 4:32 Javier Nieto
2025-08-27 10:56 ` Paul Menzel
2025-09-01 2:20 ` Javier Nieto [this message]
2025-09-29 16:01 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLUC3u3ZrF35nIb6@macbookair.lan \
--to=jgnieto@cs.stanford.edu \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®