From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABBB304BC1 for ; Mon, 1 Sep 2025 09:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756717329; cv=none; b=ia/CIpGnjjKoIMqxjA9dlDr4iLKz+Hx5JxH4ckbnJpjOC53LcC/3e9fexTa+WsEZMqxGkVkDg7KAwjdaRUWxjSw7m+xZvww+ltyIlGGvER5GeQXCsPOU4ktbvda3XmGdcjgqQySA8v4flfjhcMKBoQkASIMebU01RZ2jPx4J/sw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756717329; c=relaxed/simple; bh=dmWftgOYXnwqfimPo5iGk24UkXj0UgScTAHQx516kNY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j+azZ9rU7mrT3i4qeGEY0MwfqBiY8d6A+K3EJHjj0tqcBGwHyvp5wzHGmC1o74rh/IzicrCZ5XzdALsBCtOCbPYQT3XzfiIw/nSU7GCtP/gLfYEL5f4TDXg0QPP0IzEPeLQXh2TGF7LwhI/Ik8DjKxNpwq3ws+1GbZPCW2mMAwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tt2Q8Tru; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tt2Q8Tru" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D07AC4CEF4; Mon, 1 Sep 2025 09:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756717328; bh=dmWftgOYXnwqfimPo5iGk24UkXj0UgScTAHQx516kNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tt2Q8TruNmgq3X52QEd8IDcJOs6iK8kI1BMjyxHwgRPVldf0rLQs+CrnF0ZCB6SSW qibjwepNeMtBuTQ4KjAE/0yaNVPFZlk0w7Kr66pmIhbPfYu+JRSWlk3iCVHynRNw01 gZoEzqH/HlOS8b3hrtLNBktSWPdXEmZUTyGeMDj8FMt7MAqa4W5lqCh2fzV+EaQlgh FlInVOCdEk3w06f66JUA5G5X/iWs6JQ1MRslNQ/0yRAvyrtb++ivZ8M+XH84IBreu0 ZI2qycGpcxOt14J5/SAwvGJ8jivBZk4Fs3TWopWRnOhcT8e714jpla2JH8Q0CGAZJj +GHyEg4L6PLKQ== Date: Mon, 1 Sep 2025 12:01:59 +0300 From: Mike Rapoport To: Max Kellermann Cc: Kiryl Shutsemau , akpm@linux-foundation.org, david@redhat.com, axelrasmussen@google.com, yuanchu@google.com, willy@infradead.org, hughd@google.com, mhocko@suse.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, surenb@google.com, vishal.moola@gmail.com Subject: Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer parameters Message-ID: References: <20250831093918.2815332-1-max.kellermann@ionos.com> <20250831093918.2815332-2-max.kellermann@ionos.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Sep 01, 2025 at 10:05:53AM +0200, Max Kellermann wrote: > On Mon, Sep 1, 2025 at 9:33 AM Kiryl Shutsemau wrote: > > > > On Sun, Aug 31, 2025 at 11:39:07AM +0200, Max Kellermann wrote: > > > For improved const-correctness. > > > > It is not a proper commit message. > > I believe it is proper for something as trivial as this. I think > adding more text would just be noise, only wasting the time of people > reading it. But that is a matter of perspective: I expect every > competent C developer to know the concept of const-correctness. True, but having a brief explanation why it's ok to constify these parameters helps. Especially in longer patches. > Do you believe the commit message of 29cfe7556bfd ("mm: constify more > page/folio tests") is "proper"? -- Sincerely yours, Mike.