Re: [PATCH] crypto: qat: Use library to prepare HMAC keys

[Giovanni Cabiddu <giovanni.cabiddu@intel.com>]

On Sun, Aug 31, 2025 at 01:54:57PM -0700, Eric Biggers wrote:
> Reimplementing the sha1, sha256, and sha512 crypto_shash algorithms on
> top of the library APIs caused the recently-added function
> crypto_shash_export_core() to no longer be supported.  Meanwhile, the
> QAT driver was updated to use crypto_shash_export_core().  But it's not
> actually necessary.  Instead, just do the HMAC key preparation using the
> library functions instead of crypto_shash.  This fixes the QAT driver
> and greatly simplifies the code.  Additional benefits include stronger
> typing, and improved performance due to reduced overhead.
> 
> Reported-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Closes: https://lore.kernel.org/r/aLSnCc9Ws5L9y+8X@gcabiddu-mobl.ger.corp.intel.com
> Fixes: ccafe2821cfa ("crypto: qat - Use crypto_shash_export_core")
> Fixes: 8bc79ab67d78 ("crypto: sha1 - Wrap library and add HMAC support")
> Fixes: e0cd37169103 ("crypto: sha256 - Wrap library and add HMAC support")
> Fixes: 469acaa12502 ("crypto: sha512 - Replace sha512_generic with wrapper around SHA-512 library")
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
Thanks.

One NIT on the headline, for consistency with the other patches:
"crypto: qat -".

Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Regards,

-- 
Giovanni