From: Christoph Hellwig <hch@infradead.org>
To: Longlong Xia <xialonglong@kylinos.cn>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] block: use KMEM_CACHE instead of kmem_cache_create
Date: Mon, 1 Sep 2025 22:37:25 -0700 [thread overview]
Message-ID: <aLaClbE6jmcnGN0a@infradead.org> (raw)
In-Reply-To: <20250902033241.1623330-1-xialonglong@kylinos.cn>
On Tue, Sep 02, 2025 at 11:32:41AM +0800, Longlong Xia wrote:
> Use KMEM_CACHE() instead of kmem_cache_create() to simplify the code.
I don't see that this simplifies anything. The only thing it does
is to add yet another magic macros that needs to be followed and it
adds and overly long line.
What problem are you trying to solve with this patch?
prev parent reply other threads:[~2025-09-02 5:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 3:32 Longlong Xia
2025-09-02 5:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLaClbE6jmcnGN0a@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xialonglong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®