Re: [PATCH 3/4] sched_ext: Move internal type and accessor definitions to ext_internal.h

[Tejun Heo <tj@kernel.org>]

Hello,

On Wed, Sep 03, 2025 at 12:32:29PM +0200, Andrea Righi wrote:
> On Tue, Sep 02, 2025 at 01:48:05PM -1000, Tejun Heo wrote:
> > There currently isn't a place to place SCX-internal types and accessors to
> > be shared between ext.c and ext_idle.c. Create kernel/sched/ext_internal.h
> > and move internal type and accessor definitions there. This trims ext.c a
> > bit and makes future additions easier. Pure code reorganization. No
> > functional changes.
> 
> Having sched_ext_ops and scx_*_flags defined in ext_internal.h feels a
> bit counterintuitive, sched_ext_ops also includes the documentation for all
> the scx callbacks. How about moving these to ext.h and everything else in
> ext_internal.h?

Hmm... so, _internal headers are for things which aren't interesting to
other subsystems in the kernel. ie. internal to this particular subsystem,
which is the case here. I understand that _internal may be counter-intuitive
if the reader isn't working in the kernel tree, but am not sure that's a
primary concern in naming source files.

Thanks.

-- 
tejun