From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D2342D3740 for ; Fri, 19 Sep 2025 22:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758319883; cv=none; b=dx/nCh9mZIpJBI2ox44aOsOdabJxOGtwve7QRpDNmJpujxOCABcrJj3OeepFvRtCDblz9jH0NYLHuWnttx0kiXorMOzJdqFC6cEu5n2JFswCtR8N34uzaMnktuZgIcPCHojwbzQpBwsYBWb24vYJpDrT7JqsZfwMkJDbXgJ2/AU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758319883; c=relaxed/simple; bh=W0X6Mhm7wS8fcpKTCZiYFQOzjq2PAz99VFyTZFOC08k=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FTXZ7PY7giaJkb1sFyET90cqkFZJArfIR3LByq+3riUuFIZvIgDBCNTVdaVrAfWDyraDvRTOi7U4bn8bUfUJUqFOQTcUYBZMygGDr5EkvsywdEFgWusb1elNxxD+bY2kSWGGItukt2EPSppEeDk9v3nj3JG5jcacnYPhfb7cPM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fxSDVPG8; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fxSDVPG8" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-32eae48beaaso2687031a91.0 for ; Fri, 19 Sep 2025 15:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758319881; x=1758924681; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ZtooCHjprRGWJDpmHrwAkRKW/eZFKp/kjai25858VaA=; b=fxSDVPG8JnR2VLFT70zTAqQy/C6eAK+iQK8rHSDk9sKUqZqIljK7luoqFYOwuLPeQx UkFosrvfGgwc6UWhDWpp3XHEuGETVwqF94dNrRuLAAEUg0xdV2BzOTmk+aYtFJiErDIl 4BTRYalrgeXfGtl4PQlOtel6COcUc+Ku3G3RDpnfvMiskm/mcwmQjctoParU6Hn9n396 mHr2Rq3X/qn5DyLDhwSiujYLOPKvG/0YpDMgGbS6Kk+bpTNtPtvkZFjHCUobkx7xJR1R sR2liyjuY9BFbDhlmEfJrh8DiGksX4+/iyEa6GlsCG6N02g1DuXlUt3ePTct0dr6Gn6l zxaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758319881; x=1758924681; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZtooCHjprRGWJDpmHrwAkRKW/eZFKp/kjai25858VaA=; b=QSiGwK8xcqqNaMaEkNc6Z6Xb1iwy6ahECZrzlplZiH4v5WAHS+Xsbea5gnrREERQ3V Ht8eCpTZBl7CyJx/ot/lD6zIqr4JphK4nsFClbNWO04q2vohmgqkNdn6iV1Zk+o5gWnH JVx8XIVCCu2zJDUFFjkqCZVC6uuSLLyVtA/CqfFrJ4hKgZlqUqPPgjBQoiBd/92TsSU0 xn7zfimbSp2lpJRUEaqOKTIk8y/3YRoKOSqSJZMFb80YCo9uYA12u9XjD8NQLVNJUg20 2ARE42qGXYEprwNsGuQRXfgmTXaw6AfkBRw/0TytQcvyNbdmNpcvfFwsj1gWX5LXRdy4 76Ig== X-Forwarded-Encrypted: i=1; AJvYcCUX83REHQtVtrlR3F1gqbSrYRAW+cfmko12XaEt5zX24Mf+x0JhSC1Sva9hfUpgDom8B5B9HQyxLjxMh5Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfm48v6Hk4pYRfAsTTrBxu+T5abF/F79W7RmdmVG1JGl12qgVK kMBSpRZUaofDHu8+G9f8iDAZ+fNHqVLZR1Q7K7RBBbpCls0pwuQAsuAWKUfJ2ADm6NwI+xbgoTZ Mv60YZQ== X-Google-Smtp-Source: AGHT+IEEeeVSif0fn4CCkYFDfSXy3qALrL675gG1rH9irmCC+LZWwFQ7hk0JYzvlmgkTNPObdwsCgxTAvo8= X-Received: from pjbsv5.prod.google.com ([2002:a17:90b:5385:b0:32d:a0b1:2b14]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1e12:b0:32d:fcd8:1a9 with SMTP id 98e67ed59e1d1-33098385bd1mr5008198a91.32.1758319881426; Fri, 19 Sep 2025 15:11:21 -0700 (PDT) Date: Fri, 19 Sep 2025 15:11:20 -0700 In-Reply-To: <5afee11a-c4e9-4f44-85b8-006ab1b1433f@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250912232319.429659-1-seanjc@google.com> <20250912232319.429659-15-seanjc@google.com> <5afee11a-c4e9-4f44-85b8-006ab1b1433f@intel.com> Message-ID: Subject: Re: [PATCH v15 14/41] KVM: VMX: Emulate read and write to CET MSRs From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Lendacky , Mathias Krause , John Allen , Rick Edgecombe , Chao Gao , Maxim Levitsky , Zhang Yi Z Content-Type: text/plain; charset="us-ascii" On Tue, Sep 16, 2025, Xiaoyao Li wrote: > On 9/13/2025 7:22 AM, Sean Christopherson wrote: > > From: Yang Weijiang > > > > Add emulation interface for CET MSR access. The emulation code is split > > into common part and vendor specific part. The former does common checks > > for MSRs, e.g., accessibility, data validity etc., then passes operation > > to either XSAVE-managed MSRs via the helpers or CET VMCS fields. > > > > SSP can only be read via RDSSP. Writing even requires destructive and > > potentially faulting operations such as SAVEPREVSSP/RSTORSSP or > > SETSSBSY/CLRSSBSY. Let the host use a pseudo-MSR that is just a wrapper > > for the GUEST_SSP field of the VMCS. > > > > Suggested-by: Sean Christopherson > > Signed-off-by: Yang Weijiang > > Tested-by: Mathias Krause > > Tested-by: John Allen > > Tested-by: Rick Edgecombe > > Signed-off-by: Chao Gao > > [sean: drop call to kvm_set_xstate_msr() for S_CET, consolidate code] > > Is the change/update of "drop call to kvm_set_xstate_msr() for S_CET" true > for this patch? Yes? My comment there is stating what I did relative to the patch Chao sent. It's not relative to any existing code.