From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Madhur Kumar <madhurkumar004@gmail.com>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: cb710: Replace deprecated PCI functions
Date: Sat, 20 Sep 2025 18:25:13 +0200 [thread overview]
Message-ID: <aM7Vab4TWill5vev@qmqm.qmqm.pl> (raw)
In-Reply-To: <20250919083214.1052842-1-madhurkumar004@gmail.com>
On Fri, Sep 19, 2025 at 02:02:14PM +0530, Madhur Kumar wrote:
> pcim_iomap_table() and pcim_iomap_regions() have been deprecated.
> Replace them with pcim_iomap_region().
>
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> drivers/misc/cb710/core.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/cb710/core.c b/drivers/misc/cb710/core.c
> index 55b7ee0e8f93..033e9e6d37db 100644
> --- a/drivers/misc/cb710/core.c
> +++ b/drivers/misc/cb710/core.c
> @@ -223,13 +223,12 @@ static int cb710_probe(struct pci_dev *pdev,
> if (err)
> return err;
>
> - err = pcim_iomap_regions(pdev, 0x0001, KBUILD_MODNAME);
> - if (err)
> - return err;
>
> spin_lock_init(&chip->irq_lock);
> chip->pdev = pdev;
> - chip->iobase = pcim_iomap_table(pdev)[0];
> + chip->iobase = pcim_iomap_region(pdev, 0, KBUILD_MODNAME);
> + if(!chip->iobase)
> + return -ENOMEM;
>
> pci_set_drvdata(pdev, chip);
>
> --
> 2.51.0
>
--
Michał Mirosław
next prev parent reply other threads:[~2025-09-20 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 8:32 Madhur Kumar
2025-09-20 16:25 ` Michał Mirosław [this message]
2025-10-04 21:53 ` Madhur Kumar
2025-10-05 6:24 ` Greg KH
2025-10-07 12:43 ` Greg KH
2025-10-13 13:28 ` [PATCH v2] " Madhur Kumar
2025-11-11 15:21 ` Philipp Stanner
2025-11-11 15:59 ` Madhur Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aM7Vab4TWill5vev@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhurkumar004@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®