From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
ardb@kernel.org, Jason@zx2c4.com, qat-linux@intel.com,
giovanni.cabiddu@intel.com, ovidiu.panait.oss@gmail.com,
ebiggers@kernel.org
Subject: Re: [PATCH v2] crypto: qat - Use library to prepare HMAC keys
Date: Sat, 13 Sep 2025 12:28:27 +0800 [thread overview]
Message-ID: <aMTy60Ty6P8vNUW2@gondor.apana.org.au> (raw)
In-Reply-To: <20250905030153.11892-1-ebiggers@kernel.org>
Eric Biggers <ebiggers@kernel.org> wrote:
> To prepare HMAC keys, just use the library functions instead of
> crypto_shash. This is much simpler, avoids depending on the fragile
> export_core and import_core methods, and is faster too.
>
> Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This is the same diff as v1, but with an updated commit message and now
> targeting cryptodev/master instead of libcrypto-fixes. Since I'm going
> with
> https://lore.kernel.org/r/20250901165013.48649-1-ebiggers@kernel.org/ to
> fix the reported regression instead, this patch is now "just" a library
> conversion and not a fix per se. If needed I'd be glad to take this
> through libcrypto-next instead, but usually these conversions have been
> going through subsystem trees (which is Herbert's in this case).
>
> drivers/crypto/intel/qat/Kconfig | 7 +-
> .../crypto/intel/qat/qat_common/qat_algs.c | 191 ++++++------------
> 2 files changed, 61 insertions(+), 137 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-09-13 4:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 3:01 Eric Biggers
2025-09-13 4:28 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMTy60Ty6P8vNUW2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=giovanni.cabiddu@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ovidiu.panait.oss@gmail.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®