From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9B3F2EA493 for ; Thu, 18 Sep 2025 07:39:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758181147; cv=none; b=D56rQEUIJYREDvBELg4mqTfkOcB8qPKpRfHrWluMVn78dDc7YTpuseq3JRp2Dlhcbdwfs4LbO/9MuNw6m0plTgwZudTGtlJoZiw616clj2QOodVdQmrzb8TT6RUqVJKDVJBWwLAVwv6CIhtSsebJi3otMJMkcd5uFVoJDpEYjPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758181147; c=relaxed/simple; bh=zr9sG0j68lmhOpqFGvsTn7V0/phVlb0kkL+RjN1CCm8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kr9ir4eGumLMr/Y8lJb7SuvOtmXhqYrzhv2Q6O3gfPcxq+XUuERCbBbOwXODUWieTioElhSi1KIvbAfAcBGQZk1arb054/lfSALNga/m821+s9ulv6417Ojf54f2ws9b61ctvvo/bUbSZhpUDKIG1vjN/KrfVj37b0SRIPp2lpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jSnk2+ai; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jSnk2+ai" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4619eb18311so3785705e9.1 for ; Thu, 18 Sep 2025 00:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758181143; x=1758785943; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EXt4qIjnPyB2Xiavamfk0cWdPtVvBQPn83+TPQKe3KE=; b=jSnk2+aiclMSdfvaENwl/v13ykOt04X0HlnCTT7V30DdbrP1cXbIz/sX/4jOQugfcd Xi/GdyIfvvHyywWNX0xdppR30bM+4mesm/h3JyYDFsRkOygGVbVUukIwLREglLsFkqsQ D6uhuIgJGsWt/NJ3ZsphlSleHbyOOqctidTbMMZQwNf/7KCqKI5lo1HZ2869bL+QvVPT Yuvvp51L3BZyvPAKA62kuoaIuLHem6gAppY4jWEFb1cF3kdpMNCuf6iortAcrp7z+YCV Apxx4mjkPvxZstkUqgMpAE9ppSJwcDZcqIqGhVsS8c824zPiTQyff0Pam9GHB2YfV9WI XT1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758181143; x=1758785943; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EXt4qIjnPyB2Xiavamfk0cWdPtVvBQPn83+TPQKe3KE=; b=daOMKrRHnJSv7vtaBhRVnhUZ2xdPcz07JFHsbi8vfsg7SIri00U69QNvGlmTnAPTUc BJdgG5h9X5synnDMgUNT/zKmZ4bv1k0GVuyf9i26zV1e/kGYTt7m4PwYTPZJZd3cvVXS zqI0DqWgJCDE4QNviV1JTWhEtKiL6qzeXIbK+k7/P3f8MlxRn5tRNeKoSr3YR+ybcHor 8CZlSEjq4yQT5Y9cW5LnZHqZWyFvwteNDnAis01LRLOnuEXRammPqn4O6OOqNJy+k/4m QxemefJMvQrDiFhLiYV0dfZgwUqGIpIROqighkxjIVG09w4gOOA6SR/YC3wrP84yVN2/ mtQA== X-Forwarded-Encrypted: i=1; AJvYcCV3rVf5rimX+Xo7rGbkwn5ta3GPn/Cq8C+I2fw5u/caCbVVtpx7jJiDp3K8+KoyZNrGS+IRbBRlME/bAvE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0HavJ3AAYZegIfd/UF39RAQHoJSbd9SZz9iia4SCkyxP1+hGh fSYsZ6p2AjqYNJusWnteDpUT3TPRDmsuI9yQA3Hr7Bzsu3xlfbv1lRgHbBN6Gbvc904= X-Gm-Gg: ASbGncsj+mXKfiq0ab10nWlbmN1TaACZTZyvq8Oo+SGHfZd6+/JGvwLMhRxo0z4SRh0 69Nvw7Y2MusrlVyVhn6ToWT6SxxNhivSnfrAIeuPMHKF9EvdXqrs1/ddZn4BcMeDwHm9zdKA9dK G+Vr1KNB/q9RJfy6XspaFCcZV2SK2Eke9uz4MBCgRCvYlrpJ/untjWfMGK3symCHCpiQxUSkS/y acPN13UUXKJYnHobI0qmtUmv1TIAumbT0hNxaYWQMktgDnxbPPRYLmxrYBHuEWSLIdvsYHAfjHe tsResYx4Tpd25Qu0YsF0RKcj31RDbF8avx8VjBGyEeMQPhRKWF3fnJCS2QhBgc06jJfUyezCoWS U1qxOGvT0QGJ1Oxl6qzVPcq0HXaYStJJ5nY/dZ/Usdw3tJw== X-Google-Smtp-Source: AGHT+IH2MLUzEYKA2BPh6/SOk9G3FIKKjuMYakg7LjBGvzqYlCjhPjkDjyAhkJHpc9DvchwNU3Bf+A== X-Received: by 2002:a05:600c:5250:b0:45d:d5fb:1858 with SMTP id 5b1f17b1804b1-46205adf916mr40396985e9.21.1758181143198; Thu, 18 Sep 2025 00:39:03 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3ee0fbc72e6sm2350863f8f.29.2025.09.18.00.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 00:39:02 -0700 (PDT) Date: Thu, 18 Sep 2025 10:38:59 +0300 From: Dan Carpenter To: Fan Gong Cc: Zhu Yikai , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , linux-doc@vger.kernel.org, Jonathan Corbet , Bjorn Helgaas , luosifu , Xin Guo , Shen Chenyang , Zhou Shuai , Wu Like , Shi Jing , Luo Yang , Meny Yossefi , Gur Stavi , Lee Trager , Michael Ellerman , Vadim Fedorenko , Suman Ghosh , Przemek Kitszel , Joe Damato , Christophe JAILLET Subject: Re: [PATCH net-next v06 08/14] hinic3: Queue pair resource initialization Message-ID: References: <8d72eefd38d1c3b106eeb830d9e149df247b2906.1757653621.git.zhuyikai1@h-partners.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d72eefd38d1c3b106eeb830d9e149df247b2906.1757653621.git.zhuyikai1@h-partners.com> On Fri, Sep 12, 2025 at 02:28:25PM +0800, Fan Gong wrote: > @@ -102,6 +127,41 @@ static u32 hinic3_rx_fill_buffers(struct hinic3_rxq *rxq) > return i; > } > > +static u32 hinic3_alloc_rx_buffers(struct hinic3_dyna_rxq_res *rqres, > + u32 rq_depth, u16 buf_len) > +{ > + u32 free_wqebbs = rq_depth - 1; Why is there this "- 1" here. Why do we not allocate the last page so it's 1 page for each rq_depth? regards, dan carpenter > + u32 idx; > + int err; > + > + for (idx = 0; idx < free_wqebbs; idx++) { > + err = rx_alloc_mapped_page(rqres->page_pool, > + &rqres->rx_info[idx], buf_len); > + if (err) > + break; > + } > + > + return idx; > +} > + > +static void hinic3_free_rx_buffers(struct hinic3_dyna_rxq_res *rqres, > + u32 q_depth) > +{ > + struct hinic3_rx_info *rx_info; > + u32 i; > + > + /* Free all the Rx ring sk_buffs */ > + for (i = 0; i < q_depth; i++) { > + rx_info = &rqres->rx_info[i]; > + > + if (rx_info->page) { > + page_pool_put_full_page(rqres->page_pool, > + rx_info->page, false); > + rx_info->page = NULL; > + } > + } > +} > +